I have a fix for the "DebuggerController.Breakpoints.store is not iterable" error, but I'm still looking at the rest.
Created attachment 630105 [details] [diff] [review] Patch This patch fixes the error, but I don't quite understand why env.getVariable throws in the |arguments| case. This is the same error that js/src/jit-test/tests/debug/Frame-eval-12.js tests for, but I need to wrap my head around it.
Created attachment 630126 [details] [diff] [review] Patch v2 I reverted for...of to for each, since a for...of loop cannot be used for iterating over properties: http://mxr.mozilla.org/mozilla-central/source/js/src/jsiter.cpp#420 The "scope is not live" error stems from a change in bug 746601. Jim is the check for env.callee.live enough, or should I use a try/catch? Should I restrict such checks to name == 'arguments', too?
Comment on attachment 630126 [details] [diff] [review] Patch v2 Rob is on PTO and this is kinda urgent.
I've landed this as it's really important: https://hg.mozilla.org/integration/fx-team/rev/61e0d5d09f77 Jim, if you have any additional comments, I'll address them in the patch for bug 754251.
Backed out due to test failures: https://hg.mozilla.org/integration/fx-team/rev/198c0a1d3b51
Created attachment 631304 [details] [diff] [review] Patch v3 Had I remembered to run the tests with this patch applied, I would have seen that the env.callee.live check was too broad. I've tightened it up as I was pondering in comment 3. I need a vacation.
https://hg.mozilla.org/mozilla-central/rev/61e0d5d09f77 https://hg.mozilla.org/mozilla-central/rev/198c0a1d3b51 https://hg.mozilla.org/mozilla-central/rev/b4163cf4139e
we want to land this in Aurora, right?
Comment on attachment 631304 [details] [diff] [review] Patch v3 [Approval Request Comment] Bug caused by (feature/regressing bug #): Fix for new feature. User impact if declined: New feature will not work perfectly. Testing completed (on m-c, etc.): On m-c. Risk to taking this patch (and alternatives if risky): Actually decreases user risk through better error capture and handling. String or UUID changes made by this patch: none.
Verified as fixed on: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0 Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0