761255 - Upgrade mw32-ix-slave02, mw32-ix-slave05, mw32-ix-slave10 to NSIS 2.46u

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P1)

Comment 1

[John Hopkins (:jhopkins)]

For reference, the original NSIS upgrade bug 569534 points to this download:

 http://code.google.com/p/unsis/downloads/detail?name=nsis-2.46-Unicode-setup.exe

Install instructions used for the MoMo build VMs:

 https://bugzilla.mozilla.org/show_bug.cgi?id=670034#c7

Comment 2

[John Hopkins (:jhopkins)]

Installed:

D:\tmp> nsis-2.46-Unicode-setup.exe /S /D=d:\mozilla-build\nsis-2.46u

TODO: 
- update env.py to include that directory in the PATH.
- exclude mw32-ix-slave02 from Firefox builds.

Comment 3

[John Hopkins (:jhopkins)]

- buildbot-master34 enabled=false in production-masters.json and restricted to Thunderbird release builds only
- env.py PATH updated to point at nsis 2.46u directory.

These are local changes only (not checked in to mercurial).

win32/, win32_info.txt, and updates/win32 removed from staging build1/ directory.

A win32 build is in progress (rebuild of build1, not a new build2).

Comment 4

[John Hopkins (:jhopkins)]

Had to edit d:\mozilla-build\msys\etc\profile.d\profile-extravars.sh (as Administrator) and add d:\mozilla-build\nsis-2.46u to the PATH (ahead of the other two NSIS entries) since editing buildbot configs/buildbotcustom did not work.

A new build is in progress as of 1hr ago.

Comment 5

[John Hopkins (:jhopkins)]

One more install tweak needed:

 http://hg.mozilla.org/mozilla-build/file/0a79accba2b5/packageit.py#l132

makensis.exe needs to be renamed to makensisu-2.46.exe.
I also copied the file to makensisu.exe (like in the other NSIS install directories) to be sure as I'm under tight time constraints.

Comment 6

[John Hopkins (:jhopkins)]

The 'make installer' step chose the correct NSIS binary:

> cd instgen && d:/mozilla-build/nsis-2.46u/makensisu-2.46.exe installer.nsi

Comment 7

[John Hopkins (:jhopkins)]

I've updated profile-extrapaths.sh (note: gave wrong filename above) and installed NSIS 2.46u on mw32-ix-slave05 and mw32-ix-slave10 as well.