76130 - New messages icon not showing up on Inbox

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[scottputterman]

Using 2001041508 on Win 2000 (though I noticed this on builds from 4/13)

I see this on my IMAP account

1. Send yourself a mail
2. Wait for biff to go off
3. New message arrives in Inbox
4. Notice that the Inbox has no new message icon showing.

Filtered folders work fine, but the Inbox does not.

Comment 1

[scottputterman]

It turns out that new messages aren't getting the "New" status which probably 
explains why the folder icon doesn't change.

Comment 2

[David :Bienvenu]

I probably broke this somehow - I'll look at it.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

Comment 4

[David :Bienvenu]

cc'ing seth for sr. comments in patch. The semantics of AddNewHdrToDB are that
the caller sets the new flag on the msg hdr and add AddNewHdrToDB will reflect
that into the new set, but I broke that when I made nsMsgHdr::GetStatusFlags
check the new set. Actually, I just want to call GetRawFlags instead of GetFlags
- I'll attach a new patch.

Comment 5

[David :Bienvenu]

Attachment: more succinct change

Comment 6

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 7

[David :Bienvenu]

can I get an r= from bhuvan or gayatri so I can check this in before tomorrow's
build? thanks!

Comment 8

[(not reading, please use [e-mail] instead)]

r=sspitzer, perhaps mscott can give you a super review instead.

Comment 9

[David :Bienvenu]

*** Bug 76280 has been marked as a duplicate of this bug. ***

Comment 10

[David :Bienvenu]

fix checked in.

Comment 11

[Sheela Ravindran]

marking verified,
2001041906-win98
2001041908-mac
2001041908-linux