The test at mailnews/addrbook/test/unit/test_nsIAbCard.js is broken since I landed bug 759238. The cause is obviously at http://mxr.mozilla.org/comm-central/source/mailnews/addrbook/test/unit/test_nsIAbCard.js#45 There's an hard coded XML result of the conversion of an address book card containing an AIM screen name.
Created attachment 629910 [details] [diff] [review] WIP This make the test pass for Thunderbird, but would break the same test for SeaMonkey, as the C++ code contains ifdefs.
Created attachment 629929 [details] [diff] [review] Wallpaper patch v1 This patch wallpaper over the failure by ensuring that the XML output for translateTo("xml") and translateTo("base64xml") match our expectations for Thunderbird OR SeaMonkey. We're doing it this way because it's hard in XPCShell tests to determine which app we're in, and we're not able to do any preprocessing. Hopefully we'll come up with a more graceful solution that doesn't weaken our tests after this lands, but the priority is to have a non-busted tree. Ian: I don't have a SeaMonkey build handy. Do the nsIAbCard tests pass for you with this patch?
Comment on attachment 629929 [details] [diff] [review] Wallpaper patch v1 This is OK with me. Thanks for taking care of this!
Comment on attachment 629929 [details] [diff] [review] Wallpaper patch v1 Test works both with and without the patch for SM (which is what is expected), so r=me
Thanks for the reviews - committed to comm-central as https://hg.mozilla.org/comm-central/rev/51f29333aafd. Waiting for comm-aurora to open before I push there.
Comment on attachment 629929 [details] [diff] [review] Wallpaper patch v1 [Triage Comment] a=me for bustage fix.
Not sure why I marked this RESOLVED FIXED, since the comments in my patch mention that a more thorough fix will come from this bug.
5 years ago