Closed Bug 761326 Opened 8 years ago Closed 8 years ago

test_2d.path.arc.scale.1 assumes unrealistic 0.098 tolerance or luck

Categories

(Core :: Canvas: 2D, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

Attachments

(1 file)

This test is failing on Android (we're enabling canvas tests on Android in bug 759221).

The reason is that it's creating a 100x50 canvas, drawing a circle centered at (50, 25) with radius 56 and expects it to fully cover the whole canvas. We have

  sqrt(50^2 + 25^2) ~= 55.902

So it's assuming a drawing tolerance of roughly 56 - 55.902 == 0.098.

Drawing tolerances used in browsers are typically larger than that: we seem to use 0.3 on mobile and 0.1 on desktop, and IIUC Chrome uses 0.5.

See: http://mxr.mozilla.org/mozilla-central/ident?i=CAIRO_GSTATE_TOLERANCE_DEFAULT&filter=

This patch edits this test to work with tolerances <= 0.5 and be more explicit.

Please send it upstream.
Attachment #629930 - Flags: review?(jmuizelaar)
Attachment #629930 - Flags: feedback?(philip)
Attachment #629930 - Flags: review?(jmuizelaar) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/e158c9ebe4a2
Assignee: nobody → bjacob
Target Milestone: --- → mozilla16
Sorry, I backed this out on inbound along with bug 759221 because of failures in multiple media tests on desktop platforms:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b2b9defe6f4
Target Milestone: mozilla16 → ---
https://hg.mozilla.org/mozilla-central/rev/d71c9973b8ed
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.