Created attachment 629930 [details] [diff] [review]
fix tolerance in test_2d.path.arc.scale.1
This test is failing on Android (we're enabling canvas tests on Android in bug 759221).
The reason is that it's creating a 100x50 canvas, drawing a circle centered at (50, 25) with radius 56 and expects it to fully cover the whole canvas. We have
sqrt(50^2 + 25^2) ~= 55.902
So it's assuming a drawing tolerance of roughly 56 - 55.902 == 0.098.
Drawing tolerances used in browsers are typically larger than that: we seem to use 0.3 on mobile and 0.1 on desktop, and IIUC Chrome uses 0.5.
This patch edits this test to work with tolerances <= 0.5 and be more explicit.
Please send it upstream.
Sorry, I backed this out on inbound along with bug 759221 because of failures in multiple media tests on desktop platforms: