Closed
Bug 761465
Opened 13 years ago
Closed 13 years ago
Don't clear size cache when deleting an item
Categories
(Cloud Services Graveyard :: Server: Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rfkelly, Unassigned)
Details
(Whiteboard: [qa?])
Attachments
(1 file)
|
2.98 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
Current behaviour when deleting an item from SyncStorage is to clear the cached usage size, on the expectation that it will be recalculated to account for the reduced usage.
With Bug 756653 landed this no longer works correctly. Instead of forcing recalculation, deleting an item will now cause the cached usage size to reset to zero, providing an easy way to circumvent quota checks.
I think a better approach is to just leave the cached size alone. It will tend to over-estimate the real usage, but that's already the case as a result of other operations.
Attachment #630026 -
Flags: review?(telliott)
|
||
Updated•13 years ago
|
Whiteboard: [qa?]
|
||
Comment 1•13 years ago
|
||
Comment on attachment 630026 [details] [diff] [review]
patch to not clear cached usage size
Good catch.
Attachment #630026 -
Flags: review?(telliott) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
https://github.com/mozilla-services/server-syncstorage/commit/c9db696b4933e614ad50126519806cad4be54f95
http://hg.mozilla.org/services/server-storage/rev/1ce82c83bfd7
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•13 years ago
|
||
Will verify against Sync 1.1 and Sync 2.0.
|
||
Updated•2 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•