761653 - mutt/tests/js/frame/user_restart_multiple/test5.js fails with 'AttributeError: 'int' object has no attribute 'get''

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This test always fails:

TEST-START | /Volumes/data/code/tools/mozmill/mutt/mutt/tests/js/frame/user_restart_multiple/test5.js | testRestartAfterTimeout
DEBUG | mozmill.setTest | {"name": "testRestartAfterTimeout", "filename": "/Volumes/data/code/tools/mozmill/mutt/mutt/tests/js/frame/user_restart_multiple/test5.js"}
DEBUG | mozmill.userShutdown | {"resetProfile": false, "user": true, "restart": true}
ERROR | Test Failure: {"function": "frame.events.toggleUserShutdown", "message": "Shutdown expected but none detected before timeout", "userShutdown": 0}
DEBUG | mozmill.userShutdown | 0
TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed
RESULTS | Passed: 0
RESULTS | Failed: 0
RESULTS | Skipped: 0
ERROR | Traceback (most recent call last):
ERROR |   File "/Volumes/data/code/tools/mozmill/mozmill/mozmill/__init__.py", line 664, in run
ERROR |     mozmill.run(*self.manifest.tests)
ERROR |   File "/Volumes/data/code/tools/mozmill/mozmill/mozmill/__init__.py", line 364, in run
ERROR |     self.run_tests(*tests)
ERROR |   File "/Volumes/data/code/tools/mozmill/mozmill/mozmill/__init__.py", line 333, in run_tests
ERROR |     self.run_test_file(frame, test['path'])
ERROR |   File "/Volumes/data/code/tools/mozmill/mozmill/mozmill/__init__.py", line 295, in run_test_file
ERROR |     nextTest = self.shutdownMode.get('next')
ERROR | AttributeError: 'int' object has no attribute 'get'

It will depend on my test refactoring on bug 760418.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Regression from bug 638989. In cases like this we pass 0 as shutdownMode object to Mozmill which will then fail with shutdownMode.get().

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Pointer to Github pull-request

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 630552 [details]
Patch v1

Not sure if that's the right way to go because Mutt still complains about failed tests even the test has been marked as expected to fail:

RESULTS | Passed: 0
RESULTS | Failed: 1
RESULTS | Skipped: 0
Some tests were unsuccessful.
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Python Failures:
===========================================================================
Javascript Failures:
Exit 256: mozmill-b/Applications/Firefox/Nightly.app/--console-level=DEBUG-m/var/folders/wd/zmy4z7xn7wd7sjq90z1y52f80000gn/T/tmpyFHwQR.ini -b /Applications/Firefox/Nightly.app/ --console-level=DEBUG -m /var/folders/wd/zmy4z7xn7wd7sjq90z1y52f80000gn/T/tmpyFHwQR.ini

Also the test mentioned that we should fail with an 'Application disconnect' which doesn't happen in my case.

Comment 4

[Jeff Hammel]

Comment on attachment 630552 [details]
Patch v1

lgtm

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
https://github.com/mozautomation/mozmill/commit/ffedf9293e818346047d7aec37473be7269b2a61