76167 - crash in image insert dialogue (Classic skin)

Status: VERIFIED DUPLICATE of bug 76407

(Core :: DOM: Editor, defect)

Description

[Tracy Walker [:tracy]]

seen on mac commercial build 2001-04-16-trunk

-open composer window
-click on Image insert
	(dialogue opens)
-select an image to insert
-type in alt text

click Okay....
.....crash

mac stdlog to follow

Comment 1

[Tracy Walker [:tracy]]

Attachment: crash in image insert dialogue stack trace

Comment 2

[Kathleen :Brade]

What format is the image you tried to insert?  (gif, png, jpeg)
Is the file local or remote (what url)?

Comment 3

[Tracy Walker [:tracy]]

the image was a jpg stored locally.

Comment 4

[sujay]

I can't reproduce this on my Mac using today's build.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'd have to guess this might be related to pavlov's fix for bug 75185.

Comment 6

[kinmoz]

This should go to pavlov if it's crashing in imageRequest code.

Comment 7

[kinmoz]

Ok, I'm a bonehead, I misread the Mac stacktrace. It's crashing in 
StyleSetImpl::CantRenderReplacedElement(), so I'll put this back on the editor 
plate until my build finishes and I can verify that the cause lies elsewhere.

Comment 8

[Håkan Waara]

This works fine for me on win32 as well, trunkbuild from 10 minutes ago.

Comment 9

[kinmoz]

Tracy, this is working for me on Win32, and I'm in sync with todays tip. Do you 
mind attatching the jpg that you are crashing with?

Comment 10

[sujay]

THis was reported as a Mac issue.

Comment 11

[Tracy Walker [:tracy]]

this worked fine on windows for me as well.  

bug is Mac only.

Comment 12

[Kathleen :Brade]

I am using the 4am bits from today on Mac.
I have tried inserting jpegs from my local drive and I can't reproduce this 
problem.

Tracy--is it just the one image or can you not insert any images?  Can you load 
the images in the browser?  Can you insert the images via drag & drop?

Comment 13

[Tracy Walker [:tracy]]

I am able to drag and drop the image.  this is a work around, so reducing 
severity.  

it doesn't matter what image i use through the image insert dialogue...it always 
crashes.  I believe this may be bug 76177.  

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

It was because of the CantRenderReplacedElement stack that I thought it might be
related to pavlov's changes for bug 75185, although it's hard to tell exactly
what the problem is without knowing which variable was null/garbage.

Comment 15

[Charles Manske]

If it's really just Mac, it sure sounds like an imagelib issue to me.

Comment 16

[Tracy Walker [:tracy]]

linux commericial build 2001-04-16-10-trunk is okay..though it doesn't show the 
image in the preview pane... bug 71677

Comment 17

[Kathleen :Brade]

Sujay and I can't reproduce this on a Mac.

Tracy--can you reproduce on any other Macintosh computers or just one?  Maybe 
it's a problem with the cache or something like that?

I think it should be resolved as worksforme.

Comment 18

[sujay]

okay we see the problem now. it happens on classic skin only.

definitely a live problem.

composer crashes immediately after choosing the image from image dialog.

seen on 9.0 and 8.5 OS on Mac.

Cc: Patty Mac qa_contact for Skins

Comment 19

[Kathleen :Brade]

I see the crash with the classic skin (not with Modern).  I'm crashing in
StyleSetImpl::CantRenderReplacedElement or near
nsCSSFrameConstructor::CantRenderReplacedElement.

Comment 20

[kinmoz]

I'm going to hand this over to pavlov ... sfraser spent some time debugging it, 
and we both feel this is an image problem, not something in the editor.

I see several assertions being thrown before we crash as the result of 
nsImageFrame::OnStopDecode() calling presShell->CantRenderReplacedElement():


###!!! ASSERTION: New URI failed: 'Error', file nsProtocolProxyService.cpp, line 
302
###!!! ASSERTION: frame already has posted event: 
'!*FindPostedEventFor(aFrame)', file nsFrameManager.cpp, line 1051
###!!! ASSERTION: frame already has posted event: 
'!*FindPostedEventFor(aFrame)', file nsFrameManager.cpp, line 1051
###!!! ASSERTION: frame already has posted event: 
'!*FindPostedEventFor(aFrame)', file nsFrameManager.cpp, line 1051

Comment 21

[Tracy Walker [:tracy]]

this was not present on todays mac commercial build 2001-04-25-09-trunk

Comment 22

[Stuart Parmenter]

dup of 76407 which is fixed.

*** This bug has been marked as a duplicate of 76407 ***

Comment 23

[sujay]

verified in 4/25 build.