761704 - Unify Xray wrapper implementations

Status: REOPENED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

This is some cleanup that we've been wanting to do ever since the new bindings landed.

Here's the list I wrote down of stuff that needs to happen.

* Move nodeprincipal getter stuff into common code
* Remove wrappedJSObject getter check for XOWs, add asserts and tests
* Create separate expando object
* eagerly create expando object, simplify API
* clarify semantics of resolveOwnProperty
* make stuff CCSecurityWrapper
* desc->value

In particular, creating a separate expando object (different from the holder) is necessary for bug 761695 (and general correctness).

I don't want to do this until peter's nodelist stuff lands though. Peter, which bug is that in? Can you set the dep?

Comment 1

[Boris Zbarsky [:bzbarsky]]

> * Move nodeprincipal getter stuff into common code

Note that the long-term plan here is to make that a chromeonly prop on the Node WebIDL interface.

Comment 2

[Bobby Holley (:bholley)]

Also, it looks like we don't correctly lie about desc->obj in XrayWrapper::getPropertyDescriptor, so the existence of the holder leaks out.

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.