The default bug view has changed. See this FAQ.

Right Indent button looks like the Left Indent button in the Compose window

VERIFIED FIXED in Thunderbird 17.0

Status

Thunderbird
Theme
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: ashughes, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 17.0
x86_64
Linux
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 630234 [details]
Screenshot

See screenshot. Reproducible in Thunderbird 12.0.1 (Ubuntu bundled), 13.0 (official), and 16.0a1 Nightly.

Comment 1

5 years ago
Bwinton, Andreas, any idea where do these icons come from? I could not see them in the format-buttons.png of gnomestripe theme. But i qute (windows) the icons for indentation are in that file. Do they come from the system (gnome) theme on linux?
(Assignee)

Comment 2

5 years ago
Could this be a Linux icon theme problem I'm not seeing wizh my Linux icon theme? This icons are coming from GTK

http://hg.mozilla.org/comm-central/file/e622ef230d64/mail/themes/gnomestripe/mail/compose/messengercompose.css#l398
and
http://hg.mozilla.org/comm-central/file/e622ef230d64/mail/themes/gnomestripe/mail/compose/messengercompose.css#l405
(Assignee)

Comment 3

5 years ago
Anthony, do you still see this behavior?
(In reply to Richard Marti [:paenglab] from comment #3)
> Anthony, do you still see this behavior?

Yes. Ubuntu 12.04 64-bit, Thunderbird Daily 17.0a1 2012-08-11.
(Assignee)

Comment 5

5 years ago
Created attachment 651499 [details] [diff] [review]
patch

Anthony, you're right. I have now a totally unpatched Ubuntu 12.04 and can see your problem. My old Ubuntu always showed the icons correct with gtk-unindent-ltr and gtk-unindent-rtl. Now with unindent and intent it works on both Ubuntus.

Andreas, I hope you have a non-Ubuntu system to check if the icons are still working.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #651499 - Flags: ui-review?(nisses.mail)
Attachment #651499 - Flags: review?(nisses.mail)
I didn't see any regressions on Fedora 17 (also GTK+ 3.4), so we should be good. Going to look into the deeper cause a bit, but it works for us regardless it seems.
Comment on attachment 651499 [details] [diff] [review]
patch

Also worked well when I tried the Force RTL, so I think we're good.
Attachment #651499 - Flags: ui-review?(nisses.mail)
Attachment #651499 - Flags: ui-review+
Attachment #651499 - Flags: review?(nisses.mail)
Attachment #651499 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/e6254541c435
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Verified fixed with Thunderbird 17.0a1 2012-08-21.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.