Closed Bug 761785 Opened 9 years ago Closed 9 years ago
Background behind webpages has disappeared
On latest m-i and m-c builds the background behind web pages (i.e. what you see in overscroll) doesn't show up, it's just black.
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6b480a66acbc&tochange=a6e5cea1cee8 Sriram, I'm guessing one of your changes in this range killed the background drawable. Note that I'm seeing this on the Galaxy Nexus running ICS.
The new background texture is dark for "behind the pages". http://blog.mozilla.org/ux/2012/05/visual-reboot-of-firefox-mobile-for-android/ (esp: http://blog.mozilla.org/ux/files/2012/05/firefox_mobile_colours.png ) This is the base for the UI, and I just replaced the background as per what Ian gave me.
This is the changeset (file), that caused the change: https://hg.mozilla.org/mozilla-central/file/a6e5cea1cee8/mobile/android/base/resources/drawable-nodpi/background.png
Oh. Well then.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
(In reply to Sriram Ramasubramanian [:sriram] from comment #3) > (esp: http://blog.mozilla.org/ux/files/2012/05/firefox_mobile_colours.png ) But this spec picture shows a gray color for overscroll while the new overscroll color you used is rather black?
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Sriram, should this have been grey with texture (#575E66)
Status: REOPENED → NEW
Yes, it should be a textured grey, but a slightly darker one than what is shown in the specs. Sriram, let me know if you need a new image for this.
I understand that there are probably more important bugs to fix, but it would be nice if this regression could be fixed before 15 gets out the door. It should be just a swap of one image file AFAICS, right?
This patch fixes it. Killed 1 image -- increased size of 3 other images :P All is well! ;)
Attachment #646280 - Flags: review?(bugmail.mozilla)
9 years ago
Attachment #646280 - Flags: review?(bugmail.mozilla) → review+
Status: NEW → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Thanks a lot for fixing this, Sriram! Will you request approval for Beta and Aurora? :-)
Comment on attachment 646280 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: Black background will be shown behind webpages. Testing completed (on m-c, etc.): Landed on m-c on 07/27. Risk to taking this patch (and alternatives if risky): None. Just the resource file name changed. String or UUID changes made by this patch: None,
Comment on attachment 646280 [details] [diff] [review] Patch low risk, mobile only, approving.
Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/7b8cc0f8691b
Pushed to beta: https://hg.mozilla.org/releases/mozilla-beta/rev/a32db08b36e6
Overscroll color is correct on: Firefox Mobile 16.0b5 / Firefox Mobile 15 Samsung Galaxy R (Android 2.3.4) Marking as verified on Firefox Mobile 16 and 15
You need to log in before you can comment on or make changes to this bug.