761785 - Background behind webpages has disappeared

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

On latest m-i and m-c builds the background behind web pages (i.e. what you see in overscroll) doesn't show up, it's just black.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

So far: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73783bf75c4c&tochange=5199196b65ec

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6b480a66acbc&tochange=a6e5cea1cee8

Sriram, I'm guessing one of your changes in this range killed the background drawable. Note that I'm seeing this on the Galaxy Nexus running ICS.

Comment 3

[Sriram Ramasubramanian [:sriram]]

The new background texture is dark for "behind the pages".
http://blog.mozilla.org/ux/2012/05/visual-reboot-of-firefox-mobile-for-android/ (esp: http://blog.mozilla.org/ux/files/2012/05/firefox_mobile_colours.png )
This is the base for the UI, and I just replaced the background as per what Ian gave me.

Comment 4

[Sriram Ramasubramanian [:sriram]]

This is the changeset (file), that caused the change:
https://hg.mozilla.org/mozilla-central/file/a6e5cea1cee8/mobile/android/base/resources/drawable-nodpi/background.png

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Oh. Well then.

Comment 6

[Peter Retzer (:pretzer)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #3)
> (esp: http://blog.mozilla.org/ux/files/2012/05/firefox_mobile_colours.png )

But this spec picture shows a gray color for overscroll while the new overscroll color you used is rather black?

Comment 7

[Aaron Train [:aaronmt]]

Sriram, should this have been grey with texture (#575E66)

Comment 8

[Ian Barlow (:ibarlow)]

Yes, it should be a textured grey, but a slightly darker one than what is shown in the specs. 

Sriram, let me know if you need a new image for this.

Comment 9

[Aaron Train [:aaronmt]]

Sriram?

Comment 11

[Peter Retzer (:pretzer)]

I understand that there are probably more important bugs to fix, but it would be nice if this regression could be fixed before 15 gets out the door. It should be just a swap of one image file AFAICS, right?

Comment 12

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch fixes it.
Killed 1 image -- increased size of 3 other images :P
All is well! ;)

Comment 13

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8357f094c300

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8357f094c300

Comment 15

[Peter Retzer (:pretzer)]

Thanks a lot for fixing this, Sriram! Will you request approval for Beta and Aurora? :-)

Comment 16

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 646280 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Black background will be shown behind webpages.
Testing completed (on m-c, etc.): Landed on m-c on 07/27.
Risk to taking this patch (and alternatives if risky): None. Just the resource file name changed.
String or UUID changes made by this patch: None,

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 646280 [details] [diff] [review]
Patch

low risk, mobile only, approving.

Comment 18

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/7b8cc0f8691b

Comment 19

[Sriram Ramasubramanian [:sriram]]

Pushed to beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/a32db08b36e6

Comment 20

[Adrian Tamas (:AdrianT)]

Overscroll color is correct on: 

Firefox Mobile 16.0b5 / Firefox Mobile 15
Samsung Galaxy R (Android 2.3.4)

Marking as verified on Firefox Mobile 16 and 15