761953 - Prevent the b2g vkd from being hidden when browsing Google.com

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch v1

+++ This bug was initially created as a clone of Bug #755648 +++

Gaia issue: https://github.com/mozilla-b2g/gaia/issues/1321

The root cause of this behavior is because for some unknown reason the VKB Manager keeps getting trusted keypress event with escape key when google.com is loaded in the browser.

This patch will have VKB manager listens to keyup for hiding keyboard instead. Also, the keypress and keydown fired before keyup will be preventDefault and stopPropagation'ed.

Comment 1

[Mounir Lamouri (:mounir)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #0)
> The root cause of this behavior is because for some unknown reason the VKB
> Manager keeps getting trusted keypress event with escape key when google.com
> is loaded in the browser.

Maybe you should investigate this instead of trying to work around the issue?

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch to commit (v1)

Patch to commit if r+

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

@vingtetun, feedback?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #3)
> @vingtetun, feedback?

I would like to understand the root cause of this behavior before changing from keypress to keydown/keyup.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I can't reproduce the issue on a desktop build.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 630475 [details] [diff] [review]
Patch v1

Since I can't reproduce and the browser is broken because of 'remote', I remote the r? flag.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Doesn't happen anymore since mozKeyboard API had changed.