Closed Bug 761970 Opened 8 years ago Closed 8 years ago
Warning about missing mail-toolbar-small
.png file in pinstripe
I see this message twice in my terminal when starting a Mac debug build: Chrome file doesn't exist: /Users/florian/buildhg/comm-central/obj-tbird/mozilla/dist/DailyDebug.app/Contents/MacOS/chrome/classic/skin/classic/messenger/icons/mail-toolbar-small.png This file is referenced 3 times in the css files of the Mac theme, but doesn't exist: http://mxr.mozilla.org/comm-central/search?string=mail-toolbar-small.png&find=pinstripe&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Patch uses the monochrome icons missed to change in Bug 709799. In Web search the disabled icons are now made with opacity: .5 because the new icons have no disabled state image.
Screenshot to help for ui-review. The Web search's forward button is in disabled state. On headerToolbar the tag button on the left is the changed icon (the same as the one on main toolbar).
Comment on attachment 630630 [details] [diff] [review] patch Stealing reviews.
Comment on attachment 630630 [details] [diff] [review] patch Looks right to me - thanks Richard!
Comment on attachment 630630 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): 709799 User impact if declined: no button icon shown Risk to taking this patch (and alternatives if risky): low risk. It's only a css change
Attachment #630630 - Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Attachment #630630 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.