Last Comment Bug 761970 - Warning about missing mail-toolbar-small.png file in pinstripe
: Warning about missing mail-toolbar-small.png file in pinstripe
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: Thunderbird 16.0
Assigned To: Richard Marti (:Paenglab)
Depends on:
Blocks: 709799
  Show dependency treegraph
Reported: 2012-06-06 03:22 PDT by Florian Quèze [:florian] [:flo]
Modified: 2012-07-03 12:53 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (2.05 KB, patch)
2012-06-06 10:50 PDT, Richard Marti (:Paenglab)
mconley: review+
mconley: ui‑review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review
patch in action (7.18 KB, image/png)
2012-06-06 10:54 PDT, Richard Marti (:Paenglab)
no flags Details

Description Florian Quèze [:florian] [:flo] 2012-06-06 03:22:21 PDT
I see this message twice in my terminal when starting a Mac debug build:

Chrome file doesn't exist: /Users/florian/buildhg/comm-central/obj-tbird/mozilla/dist/

This file is referenced 3 times in the css files of the Mac theme, but doesn't exist:^[^\0]*%24&hitlimit=&tree=comm-central
Comment 1 Richard Marti (:Paenglab) 2012-06-06 10:50:33 PDT
Created attachment 630630 [details] [diff] [review]

Patch uses the monochrome icons missed to change in Bug 709799.

In Web search the disabled icons are now made with opacity: .5 because the new icons have no disabled state image.
Comment 2 Richard Marti (:Paenglab) 2012-06-06 10:54:16 PDT
Created attachment 630634 [details]
patch in action

Screenshot to help for ui-review. The Web search's forward button is in disabled state. On headerToolbar the tag button on the left is the changed icon (the same as the one on main toolbar).
Comment 3 Mike Conley (:mconley) 2012-06-06 11:03:58 PDT
Comment on attachment 630630 [details] [diff] [review]

Stealing reviews.
Comment 4 Mike Conley (:mconley) 2012-06-12 13:09:31 PDT
Comment on attachment 630630 [details] [diff] [review]

Looks right to me - thanks Richard!
Comment 5 Richard Marti (:Paenglab) 2012-06-12 13:16:19 PDT
Comment on attachment 630630 [details] [diff] [review]

[Approval Request Comment]
Regression caused by (bug #): 709799
User impact if declined: no button icon shown
Risk to taking this patch (and alternatives if risky): low risk. It's only a css change
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-06-12 13:55:05 PDT
Comment 7 Mark Banner (:standard8, afk until Dec) 2012-07-03 12:53:46 PDT
Checked in:

Note You need to log in before you can comment on or make changes to this bug.