761972 - Multiple access keys used in preferences dialog for is locale

Status: RESOLVED FIXED

(Mozilla Localizations :: is / Icelandic, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/fdec829b93b19c73985be1d388717c6b

Details:

 accessKey: l found in strings: [id: showTabBar, label: Sýna alltaf flipaslá], [id: restoreOnDemand, label: Don’t load tabs until selected]
accessKey: e found in strings: [id: privateBrowsingAutoStart, label: Nota alltaf einkavöfrun], [id: keepUntil, label: (label is undefined)]
accessKey: h found in strings: [id: (id is undefined), label: Hjálp], [id: alwaysClear, label: Hreinsa feril þegar Aurora hættir]

Comment 1

[Kristján Bjarni Guðmundsson]

OK Fixed the access keys in revision 195eb83e843e
http://hg.mozilla.org/releases/l10n/mozilla-aurora/is/rev/195eb83e843e

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's not fully fixed on aurora yet, but because of bug 762798 we are blocked in reporting all the broken nodes.

http://mozmill-crowd.blargon7.com/#/l10n/report/87961186c2b807b7747aa7e6d4070c48

 accessKey: e found in strings: [id: privateBrowsingAutoStart, label: Nota alltaf einkavöfrun], [id: keepUntil, label: (label is undefined)]
accessKey: h found in strings: [id: (id is undefined), label: Hjálp], [id: alwaysClear, label: Hreinsa feril þegar Aurora hættir]

That's with the latest 14.0a2 Aurora build which is now in beta.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The reason why we fail to process all windows with this locale is:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/is/file/195eb83e843e/browser/chrome/browser/preferences/preferences.properties#l19

cookiepermissionstitle=Undanþágur - Smákökur\n

The final backslash shouldn't be there. If you can remove this too we can hopefully check all accesskeys again. This should apply to all branches IMO.

Comment 4

[Kristján Bjarni Guðmundsson]

Ok fixed the cookiepermissionstitle aurora and beta

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I cannot verify this fix because no repack has been triggered for changeset:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/is/rev/9bf83aca9807

Chris, would you mind to check that?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh just to add it refers to bug 741756.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There are still a couple of duplicates around:

http://mozmill-ci.blargon7.com/#/l10n/report/44fc451c2e6b66b62172f2e13e23e6ad

 accessKey: "l" found in: label[control=filter][accesskey=L], button[label=Loka]
accessKey: "h" found in: button[label=Hjálp], checkbox#allowHWAccel, checkbox#alwaysCheckDefault
accessKey: "v" found in: checkbox#blockAutoRefresh, button#setDefaultButton
accessKey: "h" found in: button[label=Hjálp], button#clearCacheButton, checkbox#allowSmartSize
accessKey: "t" found in: button#connectionSettings, checkbox#offlineNotify
accessKey: "a" found in: radio[label=Setja sjálfvirkt inn uppfærslur (mælt með: eykur öryggi)], radio[label=Athuga með uppfærslur, en leyfa mér að velja hvenær á að setja þær upp]
accessKey: "l" found in: radio[label=Aldrei athuga með uppfærslur (ekki mælt með: öryggisáhætta)], checkbox#enableSearchUpdate

Comment 8

[Kristján Bjarni Guðmundsson]

I believe that there are no duplicates anymore

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have seen that our CI was not running. :/ I fixed it but we will have to wait until your next commit to the aurora branch. Once that happened please let me know and we can re-check.

Comment 10

[Kristján Bjarni Guðmundsson]

I think there are no more duplicates

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, it looks great at the moment. Thanks a lot!