Closed Bug 76203 Opened 23 years ago Closed 23 years ago

hrule icon doesn't show up in Show All Tags mode

Categories

(Core :: DOM: Editor, defect, P4)

defect

Tracking

()

VERIFIED DUPLICATE of bug 88036
mozilla1.0

People

(Reporter: Brade, Assigned: glazou)

References

Details

Attachments

(1 file)

* create a new blank editor document
 * insert an hrule
 * double-click on the hrule and make it not have 3-d shading
 * click ok in the hrule dialog
 * go to the Show All Tags mode
 * notice that there isn't an icon for the hrule
Mac only? (I'm still building today, but I know I've seen this work on Windows
last week.)
I see this on Windows builds (NS6 as well as a recent debug build).  Make sure
you do each step as described in the initial report.
OS: Mac System 8.5 → All
Hardware: Macintosh → All
The yellow "HR" icon doesn't seem to be displayed at left edge of the HR elements
frame. Thus when "noshade" is used, the gray HR hides the icon.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Depends on: 76244
Adding "depends" status -- this will be fixed when 76244 is fixed.
Nothing we can really do in Editor code.
Whiteboard: DEPENDS
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Whiteboard: DEPENDS → [behavior]DEPENDS
Priority: -- → P4
Proposing patch for this bug. I have completely rewritten EditorAllTags.css to
take advantage of generated content. To do that, I have modified the selection
so clicking on a generated content selects the element that generated it, and
patched XULPopups so double-clicking and right-clicking on generated content
in AllTags mode works.

Torture tests by torturers needed ;-)

Whiteboard: [behavior]DEPENDS → [behavior]FIX IN HAND, need r=, sr=
So the popup listener check is too slow (since you're groveling through all the 
kids to see if you're contained in the list).  We should talk to jst about 
adding a bit or something to indicate that content is generated.
Daniel: Be sure to talk to mjudge about the issue of finding generated content;
he has already explored the problem and ran into the performance issues that
hyatt notes.
I think that bit indicating generated content makes sense : there are a number of
cases where we need that information... I am open to any suggestion as soon as I
have a way, reasonably fast so hyatt does not put a spell on me, to know that a
given node is generated by its parent node.
We decided to postpone switching to using "before" strategy for All Tags mode
so we could address selection of generated content and other issues, correct?
Changing milestone to 1.0.
Target Milestone: mozilla0.9.2 → mozilla1.0
reassigning bug to myself
Assignee: cmanske → glazman
Status: ASSIGNED → NEW
New code in hand with sync with hyatt's changes in style engine + detection of
generated content reusing mjudge code (see bug 82993). Hyatt : that solves the
problem you raised about XULPopupListener :-)

About EditorAllTags.css :

                 | bytes  |  lines  |  CSS rules
-----------------+--------+---------+--------------
existing file    | 23309  |  812    |  96
-----------------+--------+---------+--------------
my file          |  4766  |  202    |  26
-----------------+--------+---------+--------------

Status: NEW → ASSIGNED
Removing the "[behavior]FIX IN HAND, need r=, sr=" status whiteboard ; I have no
fully stable fix in hand and do not seek for reviews for the moment
Whiteboard: [behavior]FIX IN HAND, need r=, sr=

*** This bug has been marked as a duplicate of 88036 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.