Last Comment Bug 762044 - Move content/html/content/test/test_bug660238.html into content/html/content/tests/forms/
: Move content/html/content/test/test_bug660238.html into content/html/content/...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on: 748238
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-06 07:29 PDT by Mounir Lamouri (:mounir)
Modified: 2012-06-08 13:58 PDT (History)
1 user (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (145 bytes, patch)
2012-06-06 07:29 PDT, Mounir Lamouri (:mounir)
no flags Details | Diff | Splinter Review
Patch (1.68 KB, patch)
2012-06-06 07:34 PDT, Mounir Lamouri (:mounir)
Ms2ger: review+
mounir: checkin+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2012-06-06 07:29:12 PDT
Created attachment 630562 [details] [diff] [review]
Patch
Comment 1 Mounir Lamouri (:mounir) 2012-06-06 07:34:43 PDT
Created attachment 630563 [details] [diff] [review]
Patch

That might be better ;)
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-06-06 09:44:17 PDT
Comment on attachment 630563 [details] [diff] [review]
Patch

Review of attachment 630563 [details] [diff] [review]:
-----------------------------------------------------------------

While you're here....

var errorString = "foo";
if (!expectedResult) {
  errorString = "bar";
}

should be

var errorString = expectedResult
                  ? "foo"
                  : bar;

and

for each(var test in tests) {

should be

for (var test of tests) {

r=me with those things fixed.
Comment 3 Ed Morley [:emorley] 2012-06-08 13:58:36 PDT
https://hg.mozilla.org/mozilla-central/rev/89e71d2ea54d

Note You need to log in before you can comment on or make changes to this bug.