The default bug view has changed. See this FAQ.

Move content/html/content/test/test_bug660238.html into content/html/content/tests/forms/

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 630562 [details] [diff] [review]
Patch
Attachment #630562 - Flags: review?(Ms2ger)
(Assignee)

Comment 1

5 years ago
Created attachment 630563 [details] [diff] [review]
Patch

That might be better ;)
Attachment #630562 - Attachment is obsolete: true
Attachment #630562 - Flags: review?(Ms2ger)
Attachment #630563 - Flags: review?(Ms2ger)
Comment on attachment 630563 [details] [diff] [review]
Patch

Review of attachment 630563 [details] [diff] [review]:
-----------------------------------------------------------------

While you're here....

var errorString = "foo";
if (!expectedResult) {
  errorString = "bar";
}

should be

var errorString = expectedResult
                  ? "foo"
                  : bar;

and

for each(var test in tests) {

should be

for (var test of tests) {

r=me with those things fixed.
Attachment #630563 - Flags: review?(Ms2ger) → review+
(Assignee)

Updated

5 years ago
Flags: in-testsuite-
Target Milestone: --- → mozilla16
(Assignee)

Updated

5 years ago
Attachment #630563 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/89e71d2ea54d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.