Closed
Bug 762044
Opened 13 years ago
Closed 13 years ago
Move content/html/content/test/test_bug660238.html into content/html/content/tests/forms/
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.68 KB,
patch
|
Ms2ger
:
review+
mounir
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #630562 -
Flags: review?(Ms2ger)
| Assignee | ||
Comment 1•13 years ago
|
||
That might be better ;)
Attachment #630562 -
Attachment is obsolete: true
Attachment #630562 -
Flags: review?(Ms2ger)
Attachment #630563 -
Flags: review?(Ms2ger)
Comment 2•13 years ago
|
||
Comment on attachment 630563 [details] [diff] [review]
Patch
Review of attachment 630563 [details] [diff] [review]:
-----------------------------------------------------------------
While you're here....
var errorString = "foo";
if (!expectedResult) {
errorString = "bar";
}
should be
var errorString = expectedResult
? "foo"
: bar;
and
for each(var test in tests) {
should be
for (var test of tests) {
r=me with those things fixed.
Attachment #630563 -
Flags: review?(Ms2ger) → review+
| Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla16
| Assignee | ||
Updated•13 years ago
|
Attachment #630563 -
Flags: checkin+
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•