Closed Bug 762062 Opened 12 years ago Closed 7 years ago

Firefox startup crash in JS_HoldPrincipals (Correlation to Skype 6.0.0.10201)

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Version:
13 Branch
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox13 + ---

People

(Reporter: marcia, Unassigned)

References

Details

(Keywords: crash, Whiteboard: [startupcrash])

Crash Data

This bug was filed from the Socorro interface and is 
report bp-12ec2167-e34a-4345-a4be-b30a02120605 .
============================================================= 

Seen while looking at Beta 13 data - https://crash-stats.mozilla.com/report/list?signature=JS_HoldPrincipals. Relatively low volume crash so far but early in the cycle. Will need to drill down in manual reports to get the version of Skype that is causing the issue.

Frame 	Module 	Signature 	Source
0 	mozjs.dll 	JS_HoldPrincipals 	js/src/jsapi.cpp:4460
1 	mozjs.dll 	js::TokenStream::TokenStream 	js/src/frontend/TokenStream.cpp:161
2 	mozjs.dll 	js::Parser::Parser 	js/src/frontend/Parser.cpp:133
3 	mozjs.dll 	js::frontend::CompileScript 	js/src/frontend/BytecodeCompiler.cpp:338
4 	mozjs.dll 	EvaluateUCScriptForPrincipalsCommon 	js/src/jsapi.cpp:5303
5 	mozjs.dll 	JS_EvaluateUCScriptForPrincipalsVersionOrigin 	js/src/jsapi.cpp:5346
6 	xul.dll 	nsJSContext::EvaluateString 	dom/base/nsJSEnvironment.cpp:1448
7 	SkypeFfComponent.dll 	SkypeFfComponent.dll@0x5753c 	
8 	SkypeFfComponent.dll 	SkypeFfComponent.dll@0x7980e 	
9 	SkypeFfComponent.dll 	SkypeFfComponent.dll@0x83e65 	
10 	SkypeFfComponent.dll 	SkypeFfComponent.dll@0x84233 	
11 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
12 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2323
13 	xul.dll 	XPC_WN_CallMethod 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1539
14 	xul.dll 	xul.dll@0xba38f 	
15 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:514
16 	mozjs.dll 	js::Interpret 	js/src/jsinterp.cpp:2711
17 	mozjs.dll 	js::RunScript 	js/src/jsinterp.cpp:461
18 	mozjs.dll 	js::ExecuteKernel 	js/src/jsinterp.cpp:668
19 	mozjs.dll 	js::Execute 	js/src/jsinterp.cpp:710
20 	mozjs.dll 	JS_ExecuteScript 	js/src/jsapi.cpp:5275
21 	xul.dll 	nsJSContext::ExecuteScript 	dom/base/nsJSEnvironment.cpp:1591
22 	xul.dll 	nsGlobalWindow::EnsureScriptEnvironment 	dom/base/nsGlobalWindow.cpp:1598
23 	xul.dll 	nsXULDocument::ExecuteScript 	content/xul/document/src/nsXULDocument.cpp:3634
24 	xul.dll 	nsXULDocument::OnStreamComplete 	content/xul/document/src/nsXULDocument.cpp:3506
25 	xul.dll 	nsStreamLoader::OnStopRequest 	netwerk/base/src/nsStreamLoader.cpp:127
26 	xul.dll 	nsJARChannel::OnStopRequest 	modules/libjar/nsJARChannel.cpp:924
27 	xul.dll 	nsInputStreamPump::OnStateStop 	netwerk/base/src/nsInputStreamPump.cpp:583
28 	xul.dll 	nsInputStreamPump::OnInputStreamReady 	netwerk/base/src/nsInputStreamPump.cpp:405
29 	xul.dll 	nsInputStreamReadyEvent::Run 	xpcom/io/nsStreamUtils.cpp:114
30 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:657
31 	xul.dll 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:110
32 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:201
33 	xul.dll 	MessageLoop::Run 	ipc/chromium/src/base/message_loop.cc:175
34 	xul.dll 	nsBaseAppShell::Run 	widget/xpwidgets/nsBaseAppShell.cpp:189
35 	xul.dll 	nsAppShell::Run 	widget/windows/nsAppShell.cpp:252
36 	xul.dll 	nsAppStartup::Run 	toolkit/components/startup/nsAppStartup.cpp:295
37 	xul.dll 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3703
38 	firefox.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:107
39 	firefox.exe 	__tmainCRTStartup 	crtexe.c:552
40 	ntdll.dll 	__RtlUserThreadStart 	
41 	kernel32.dll 	LoadStringByReference 	
42 	kernel32.dll 	LoadStringByReference
JS_HoldPrincipals|EXCEPTION_ACCESS_VIOLATION_WRITE (63 crashes)
    100% (63/63) vs.   0% (129/49435) SkypeFfComponent.dll
          0% (0/63) vs.   0% (1/49435) 5.10.0.9560
          0% (0/63) vs.   0% (3/49435) 5.11.0.9874
          0% (0/63) vs.   0% (2/49435) 5.6.0.8312
          0% (0/63) vs.   0% (2/49435) 5.6.0.8442
          0% (0/63) vs.   0% (1/49435) 5.7.0.8773
          0% (0/63) vs.   0% (5/49435) 5.9.0.9216
        100% (63/63) vs.   0% (103/49435) 6.0.0.10201
          0% (0/63) vs.   0% (12/49435) 6.0.0.10219
Summary: Firefox startup crash in JS_HoldPrincipals (Correlation to Skype) → Firefox startup crash in JS_HoldPrincipals (Correlation to Skype 6.0.0.10201)
Adding Kev.
It's #18 top browser crasher in the first days of 13.0.
Keywords: topcrash
I wasn't able to repro this on Windows so far using the specific version showing up in the correlations.

In the channel meeting I was asked about specifics as to when we started seeing this crash emerge. According to crash stats, the signature was seen in 12 but in much smaller numbers. It was present in some of the 13 betas and seem to to have increased between Beta 6 (16 crashes) Beta 7 with 171 crashes. Currently FF 13 has 227 crashes in this signature.
Here are some additional addon correlations:

Looks as if some of the crashers have the Yandex bar as well. The 46% correlation maps to Skype Click to Call (http://www.systemlookup.com/FF_Extensions/456-Skype_extension_Click_to_call_with_Skype.html)

JS_HoldPrincipals|EXCEPTION_ACCESS_VIOLATION_WRITE (156 crashes)
     46% (72/156) vs.   0% (237/63566) {82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}
     27% (42/156) vs.   2% (1502/63566) {37964A3C-4EE8-47b1-8321-34DE2C39BA4D}
     22% (35/156) vs.   3% (2023/63566) yasearch@yandex.ru (Yandex.Bar, https://addons.mozilla.org/addon/3495)
     25% (39/156) vs.   6% (3981/63566) jqs@sun.com (Java Quick Starter, http://java.sun.com/javase/downloads/)
     13% (21/156) vs.   4% (2491/63566) {20a82645-c095-46ed-80e3-08825760534b} (Microsoft .NET Framework Assistant, http://www.windowsclient.net/)
      7% (11/156) vs.   0% (51/63566) SQLiteManager@mrinalkant.blogspot.com (SQLite Manager, https://addons.mozilla.org/addon/5817)
      6% (10/156) vs.   0% (15/63566) php_dev_bar@php_dev_bar.org (PHP Developer Toolbar, https://addons.mozilla.org/addon/12686)
      6% (10/156) vs.   0% (18/63566) scrapbookplus@addons.mozilla.org (ScrapBook Plus, https://addons.mozilla.org/addon/8186)
      6% (10/156) vs.   0% (24/63566) abhere2@moztw.org (Add Bookmark Here ², https://addons.mozilla.org/addon/3880)
      6% (10/156) vs.   0% (72/63566) {3e9bb2a7-62ca-4efa-a4e6-f6f6168a652d} (ShowIP, https://addons.mozilla.org/addon/590)
      6% (10/156) vs.   1% (345/63566) {c45c406e-ab73-11d8-be73-000a95be3b12} (Web Developer, https://addons.mozilla.org/addon/60)
      6% (10/156) vs.   1% (530/63566) {73a6fe31-595d-460b-a920-fcc0f8843232} (NoScript, https://addons.mozilla.org/addon/722)
      6% (9/156) vs.   1% (347/63566) {B100D0FF-0001-8CE4-2790-AACE49B8AE35}
      7% (11/156) vs.   2% (1198/63566) {D4DD63FA-01E4-46a7-B6B1-EDAB7D6AD389} (Download Statusbar, https://addons.mozilla.org/addon/26)
     10% (16/156) vs.   5% (3283/63566) wrc@avast.com
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0

I was not able to crash Firefox even with the Yander bar or with the Skype Click to Call installed. 
Also, I installed all the extensions mentioned in Comment 5 (except for Avast) and, again, I was not able to crash Firefox even if I used it intensively (playing games, videos, used the extensions, read media, etc).
Same results as Simona with Skype Click to Call and Yandex Toolbar installed on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0.
This currently ranks as the #13 top crash in FF 13 with 1533 crashes in the last week. A fair number of the 133 crash comments are in Russian.
This currently is the #2 startup crash signature in Firefox 13, at #18 overall in that version.
During the channel meeting I was asked to check if this signature exists in 14 data - I just did a query and JS_HoldPrincipals does not show in FF 14 data currently. Crashes show up in FF 13 and a handful in FF 12.
As Benjamin pointed out in the meeting, this add-on most likely has a binary component and probably won't support 14 until it is closer to be released. This means that we can't use 14 as a testing ground for a block.
Depends on: 765626
Current correlations for 13.0.1:

Add-ons:

  JS_HoldPrincipals|EXCEPTION_ACCESS_VIOLATION_WRITE (184 crashes)
     54% (99/184) vs.   2% (927/56965) {82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}
     24% (44/184) vs.   3% (1525/56965) {37964A3C-4EE8-47b1-8321-34DE2C39BA4D}
     19% (35/184) vs.   3% (1927/56965) yasearch@yandex.ru (Yandex.Bar, https://addons.mozilla.org/addon/3495)
     14% (26/184) vs.   5% (2679/56965) jqs@sun.com (Java Quick Starter, http://java.sun.com/javase/downloads/)
     14% (25/184) vs.   7% (4084/56965) wrc@avast.com
     10% (18/184) vs.   3% (1954/56965) {20a82645-c095-46ed-80e3-08825760534b} (Microsoft .NET Framework Assistant, http://www.windowsclient.net/)

Modules:

  JS_HoldPrincipals|EXCEPTION_ACCESS_VIOLATION_WRITE (184 crashes)
    100% (184/184) vs.   1% (629/56965) SkypeFfComponent.dll
    100% (184/184) vs.   8% (4715/56965) GdiPlus.dll
    (and others with less significance)

As a reminder, those lines mean "x% (of crashes with this signature) vs. y% (of all crashes) have this add-on/module listed". With that in mind, the SkypeFfComponent.dll correlation is pretty obvious and clear, the add-on correlations are all not conclusive, though the first one is a strong pointer - all others, including the Yandex.Bar one I got questions about, don't let us make conclusions about them causing anything, may give us some clues about potentially affected demographics, though.
There's only one crash in 15.0.1.
Keywords: topcrash
I'm marking this bug as WORKSFORME as bug crashlog signature didn't appear from a long time (over half year) in Firefox (except some obsolete Fx <35).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.