Closed Bug 762088 Opened 10 years ago Closed 10 years ago

nsContentPrefService.js, reference to undefined property Cc['@mozilla.org/privatebrowsing;1']

Categories

(Toolkit :: General, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(2 files)

Attached patch PatchSplinter Review
With Thunderbird, I sometimes see this warning:
JavaScript strict warning: file:///Users/florian/buildhg/comm-central/obj-tbird/mozilla/dist/DailyDebug.app/Contents/MacOS/components/nsContentPrefService.js, line 106: reference to undefined property Cc['@mozilla.org/privatebrowsing;1']

This looks like another instance of the warnings that were already fixed in bug 748889, and this code was inserted in bug 679784.
Attachment #630595 - Flags: review?(ehsan)
Comment on attachment 630595 [details] [diff] [review]
Patch

Review of attachment 630595 [details] [diff] [review]:
-----------------------------------------------------------------

Now that you have added this check, you can get rid of the try/catch block.  r=me with that, and thanks for catching this!
Attachment #630595 - Flags: review?(ehsan) → review+
Assignee: nobody → florian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f83e4800faf

(Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.