Closed
Bug 762088
Opened 13 years ago
Closed 13 years ago
nsContentPrefService.js, reference to undefined property Cc['@mozilla.org/privatebrowsing;1']
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(2 files)
|
928 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
1.17 KB,
patch
|
Details | Diff | Splinter Review |
With Thunderbird, I sometimes see this warning:
JavaScript strict warning: file:///Users/florian/buildhg/comm-central/obj-tbird/mozilla/dist/DailyDebug.app/Contents/MacOS/components/nsContentPrefService.js, line 106: reference to undefined property Cc['@mozilla.org/privatebrowsing;1']
This looks like another instance of the warnings that were already fixed in bug 748889, and this code was inserted in bug 679784.
Attachment #630595 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 630595 [details] [diff] [review]
Patch
Review of attachment 630595 [details] [diff] [review]:
-----------------------------------------------------------------
Now that you have added this check, you can get rid of the try/catch block. r=me with that, and thanks for catching this!
Attachment #630595 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → florian
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla16
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2f83e4800faf
(Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•