nsContentPrefService.js, reference to undefined property Cc['@mozilla.org/privatebrowsing;1']

RESOLVED FIXED in mozilla16

Status

()

--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 630595 [details] [diff] [review]
Patch

With Thunderbird, I sometimes see this warning:
JavaScript strict warning: file:///Users/florian/buildhg/comm-central/obj-tbird/mozilla/dist/DailyDebug.app/Contents/MacOS/components/nsContentPrefService.js, line 106: reference to undefined property Cc['@mozilla.org/privatebrowsing;1']

This looks like another instance of the warnings that were already fixed in bug 748889, and this code was inserted in bug 679784.
Attachment #630595 - Flags: review?(ehsan)

Comment 1

7 years ago
Comment on attachment 630595 [details] [diff] [review]
Patch

Review of attachment 630595 [details] [diff] [review]:
-----------------------------------------------------------------

Now that you have added this check, you can get rid of the try/catch block.  r=me with that, and thanks for catching this!
Attachment #630595 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

7 years ago
Created attachment 630959 [details] [diff] [review]
Patch v2 (for check-in)
Assignee: nobody → florian
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Comment 3

7 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f83e4800faf
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/2f83e4800faf

(Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.