Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Simplify ParseMappedAttrAnimValueCallback

RESOLVED FIXED in mozilla16

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Robert Longson, Assigned: Robert Longson)

Tracking

Trunk
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 630613 [details] [diff] [review]
patch
Assignee: nobody → longsonr
Attachment #630613 - Flags: review?(dholbert)
Attachment #630613 - Flags: review?(dholbert) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/14bea2e7f431
Flags: in-testsuite-
Target Milestone: --- → mozilla16

Comment 3

5 years ago
Sorry had to back out for failing to compile on any platform:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=14bea2e7f431

https://hg.mozilla.org/integration/mozilla-inbound/rev/30fc3d3e10d3

Please can you test locally (or ideally batch a few things up and send to try) before landing on inbound.
Target Milestone: mozilla16 → ---
(Assignee)

Comment 4

5 years ago
It did compile locally on windows. I'll make sure it compiles everywhere before relanding.
(Assignee)

Comment 5

5 years ago
Created attachment 630906 [details] [diff] [review]
fix for non-windows compilers
Attachment #630613 - Attachment is obsolete: true
Attachment #630906 - Flags: review?(dholbert)
(Assignee)

Updated

5 years ago
Attachment #630906 - Attachment is obsolete: true
Attachment #630906 - Flags: review?(dholbert)
(Assignee)

Comment 6

5 years ago
Created attachment 630915 [details] [diff] [review]
appease non-windows compilers
Attachment #630915 - Flags: review?(dholbert)
(Assignee)

Comment 7

5 years ago
Created attachment 630916 [details] [diff] [review]
appease non-windows compilers

the right patch this time.
Attachment #630915 - Attachment is obsolete: true
Attachment #630915 - Flags: review?(dholbert)
Attachment #630916 - Flags: review?(dholbert)
Attachment #630916 - Flags: review?(dholbert) → review+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/80e0fe778213
Target Milestone: --- → mozilla16

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/80e0fe778213
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.