Last Comment Bug 762119 - Simplify ParseMappedAttrAnimValueCallback
: Simplify ParseMappedAttrAnimValueCallback
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Robert Longson
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-06 10:17 PDT by Robert Longson
Modified: 2012-06-08 13:59 PDT (History)
1 user (show)
longsonr: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.19 KB, patch)
2012-06-06 10:18 PDT, Robert Longson
dholbert: review+
Details | Diff | Splinter Review
fix for non-windows compilers (1.55 KB, patch)
2012-06-07 03:01 PDT, Robert Longson
no flags Details | Diff | Splinter Review
appease non-windows compilers (1.55 KB, patch)
2012-06-07 04:19 PDT, Robert Longson
no flags Details | Diff | Splinter Review
appease non-windows compilers (2.55 KB, patch)
2012-06-07 04:20 PDT, Robert Longson
dholbert: review+
Details | Diff | Splinter Review

Description Robert Longson 2012-06-06 10:17:59 PDT

    
Comment 1 Robert Longson 2012-06-06 10:18:27 PDT
Created attachment 630613 [details] [diff] [review]
patch
Comment 3 Ed Morley [:emorley] 2012-06-07 01:42:59 PDT
Sorry had to back out for failing to compile on any platform:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=14bea2e7f431

https://hg.mozilla.org/integration/mozilla-inbound/rev/30fc3d3e10d3

Please can you test locally (or ideally batch a few things up and send to try) before landing on inbound.
Comment 4 Robert Longson 2012-06-07 01:54:00 PDT
It did compile locally on windows. I'll make sure it compiles everywhere before relanding.
Comment 5 Robert Longson 2012-06-07 03:01:38 PDT
Created attachment 630906 [details] [diff] [review]
fix for non-windows compilers
Comment 6 Robert Longson 2012-06-07 04:19:44 PDT
Created attachment 630915 [details] [diff] [review]
appease non-windows compilers
Comment 7 Robert Longson 2012-06-07 04:20:32 PDT
Created attachment 630916 [details] [diff] [review]
appease non-windows compilers

the right patch this time.
Comment 9 Ed Morley [:emorley] 2012-06-08 13:59:25 PDT
https://hg.mozilla.org/mozilla-central/rev/80e0fe778213

Note You need to log in before you can comment on or make changes to this bug.