76227 - two asserts every second from imgContainer.cpp

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Mike Pinkerton (not reading bugmail)]

pull from 4/16/01, noonish.

###!! ASSERTION: uh: 'mTimer == timer', file imgContainer.cpp, line 328

forever, about 2 a second. can't debug with product.

Comment 1

[Simon Fraser [no longer active]]

I don't see this in my builds from today. URL?

Comment 2

[Mike Pinkerton (not reading bugmail)]

any url. no url. happens with no windows, happens with emtpy windows. happens on 
a plane, happens on a train.

Comment 3

[Stuart Parmenter]

this only seems to happen with pink's magic machine.

Comment 4

[Stuart Parmenter]

this shouldn't be a smoketest blocker since asserts only happen in debug builds 
and not optimized ones that people are running the smoketests on :)

Comment 5

[Akkana Peck]

Do you see it on a gif?  Do you throw it off a cliff?

This might be an interaction between my checkin and some of Pav's recent
changes.  I made imgContainer start the animation timer later than it previously
did, from StartAnimation.  I wasn't seeing any asserts in my linux build before
checking in, and only on animated images.  If Pink is the only one seeing it, it
may be hard to debug ...  Maybe there's some assumption triggered somehow in his
environment that there's a timer even if there's no animated image?  Updating my
build now.

Comment 6

[Akkana Peck]

Editing screwup on the last message: ", and only on animated images" should have
been after "from StartAnimation", i.e. only start the timer on animated images.
 It sounded like I was seeing asserts on animated images, which isn't the case.

Comment 7

[Akkana Peck]

No luck testing this on my build -- I'm getting 2147549183 (NS_ERROR_UNEXPECTED)
when I try to load any url.  I was seeing this last night, too, after I updated
in mid-afternoon.  Maybe it's related to the
###!!! ASSERTION: New URI failed: 'Error', file nsProtocolProxyService.cpp, line 302
I get when starting up.

Comment 8

[Simon Fraser [no longer active]]

That last assertion is bug 53080.

Comment 9

[Akkana Peck]

What I was seeing was a cache problem -- I'm running again after removing my
Cache and NewCache dirs.  I do not see this assert, on blank pages, pages with
animated images, or pages with non-animated images.

Comment 10

[Simon Fraser [no longer active]]

Cache problem, so there is a workaround -- delete your cache dir(s). So not a 
smoketest blocker

Comment 11

[gordon]

who can reproduce this?

Comment 12

[Mike Pinkerton (not reading bugmail)]

i pitched my cache and still have the same problem. Nyah!

Comment 13

[gordon]

Victory is MINE!

Comment 14

[Mike Pinkerton (not reading bugmail)]

repeating timer cancelled in callback causes this. not sure why no one else sees 
it. everyone should. smfr's patch in 74827 fixes the problems.

Comment 15

[Stuart Parmenter]

smfr checked in his fix. marking this one fixed.

Comment 16

[Terri Preston]

Verified