background color in cell tab shouldn't get checked on cancel

VERIFIED FIXED in mozilla0.9.1

Status

()

Core
Editor
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Brade, Assigned: Charles Manske)

Tracking

Trunk
mozilla0.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: FIX IN HAND)

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
In the table dialog, in the cell tab, if I click on the color picker and then
click on the cancel button, the checkbox gets checked even though I haven't
changed anything.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
(Assignee)

Comment 1

17 years ago
Created attachment 31056 [details] [diff] [review]
fixes enable states for rowcount=1 and colcount=1 cases
(Assignee)

Comment 2

17 years ago
Fix is ready for review
Keywords: patch, review
Whiteboard: FIX IN HAND need r=, sr=
(Assignee)

Comment 3

17 years ago
Ignore patch! Wrong bug.
Keywords: patch, review
Whiteboard: FIX IN HAND need r=, sr=
(Assignee)

Comment 4

17 years ago
Created attachment 31153 [details] [diff] [review]
The correct fix: Move setting checkbox until after test for Cancel key
(Assignee)

Comment 5

17 years ago
Last patch is correct fix.
Keywords: patch, review
Whiteboard: FIX IN HAND need r=, sr=
(Reporter)

Comment 6

17 years ago
looks good; r=brade
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND need sr=
(Assignee)

Comment 8

17 years ago
Removing "need sr"
Whiteboard: FIX IN HAND need sr= → FIX IN HAND
(Assignee)

Comment 9

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

17 years ago
checked in
(Reporter)

Comment 11

17 years ago
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.