762288 - Change bugs_activity.removed to match data type of bugs_activity.added

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[David Lawrence [:dkl]]

Currently bugs_activity.added is set to varchar(255) and bugs_activity.removed is set up as tinytext (255 chars) and the should match. added was converted few years back to make indexing for duplicates.cgi better, but removed was not changed at the time. tinytext actually will contain less that 255 chars if multibyte characters are used such as utf8. varchar(255) does not have that limitation and will still allow 255 multibyte chars.

Patch coming.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to change bugs_activity.removed to varchar(255) (v1)

Comment 2

[Frédéric Buclin]

Comment on attachment 630752 [details] [diff] [review]
Patch to change bugs_activity.removed to varchar(255) (v1)

>=== modified file 'Bugzilla/Install/DB.pm'


>+    $dbh->bz_add_index('bugs_activity', 'bugs_activity_removed_idx', ['removed']);

There is no such index in the DB schema. Also, do we need this index for real?

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to change bugs_activity.removed to varchar(255) (v2)

Mainly I added the index for consistency and it doesn't really hurt anything to have it there. It could be useful for queries using 'changedfrom' or if some other cgi in the future similar to duplicates.cgi were to start using the 'removed' column extensively.

dkl

Comment 4

[Frédéric Buclin]

Comment on attachment 630970 [details] [diff] [review]
Patch to change bugs_activity.removed to varchar(255) (v2)

r=LpSolit

Comment 5

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/Install/DB.pm
modified Bugzilla/DB/Schema.pm
Committed revision 8269.