The default bug view has changed. See this FAQ.

Allow Sleep button to bubble from browser frames

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: timdream, Assigned: vingtetun)

Tracking

Trunk
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 5 obsolete attachments)

+++ This bug was initially created as a clone of Bug #757486 +++

Per discussion on bug 755648 comment 25, add Sleep button to the whitelisted events for browser frames to bubble, feature introduced in Bug #757486.
Created attachment 630823 [details] [diff] [review]
Patch to commit (v1)

Patch v1, for commit, if r+
Attachment #630823 - Flags: review?(21)
Comment on attachment 630823 [details] [diff] [review]
Patch to commit (v1)

It's kind of silly, but can you modify the test so we don't regress this?  (dom/tests/mochitest/test_browserFrame_keyEvents.html)
Attachment #630823 - Flags: review?(21) → review-
Created attachment 630834 [details] [diff] [review]
Patch to commit (v2)

Also add the sleep button to mochitest
Attachment #630823 - Attachment is obsolete: true
Attachment #630834 - Flags: review?(21)
(In reply to Justin Lebar [:jlebar] from comment #2)
> Comment on attachment 630823 [details] [diff] [review]
> Patch to commit (v1)
> 
> It's kind of silly, but can you modify the test so we don't regress this? 
> (dom/tests/mochitest/test_browserFrame_keyEvents.html)

Just did, thanks.
Comment on attachment 630834 [details] [diff] [review]
Patch to commit (v2)

That doesn't actually do anything; read the rest of the test.  :)  (Particularly, the bottom, under runTest().)
Attachment #630834 - Flags: review?(21) → review-
Created attachment 630842 [details] [diff] [review]
Patch v3

Now this should make sense ...
Attachment #630834 - Attachment is obsolete: true
Attachment #630842 - Flags: review?(21)
Comment on attachment 630842 [details] [diff] [review]
Patch v3

I think you also need to modify nbEvents, but yes.  :)
Attachment #630842 - Flags: review?(21) → review+
(In reply to Justin Lebar [:jlebar] from comment #7)
> I think you also need to modify nbEvents, but yes.  :)

What do you mean? Do I need to make more modification?
Created attachment 630846 [details] [diff] [review]
Patch to commit

If there is no further modification required, this is the patch to commit.
Keywords: checkin-needed
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #8)
> (In reply to Justin Lebar [:jlebar] from comment #7)
> > I think you also need to modify nbEvents, but yes.  :)
> 
> What do you mean? Do I need to make more modification?

Yes, I think so.  See |var nbEvents = 15;|.
Keywords: checkin-needed
Created attachment 630847 [details] [diff] [review]
Patch to commit

nbEvents=16
Attachment #630846 - Attachment is obsolete: true
@jliebar suggests this could go through try-server before landing. @vingtetun, @mounir, thought?
*Everything* has to go through try server before being pushed to m-i or m-c.
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #12)
> @jliebar suggests this could go through try-server before landing.
> @vingtetun, @mounir, thought?

Tim do you have a Level 1 access ? (http://www.mozilla.org/hacking/commit-access-policy/)
(In reply to Vivien Nicolas (:vingtetun) from comment #14)
> (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #12)
> > @jliebar suggests this could go through try-server before landing.
> > @vingtetun, @mounir, thought?
> 
> Tim do you have a Level 1 access ?
> (http://www.mozilla.org/hacking/commit-access-policy/)

I do (bug 726492), but I've never use it and I got Error when I tried to push to try:

$ hg push -f ssh://hg.mozilla.org/try/ -e 'ssh -l tchien@mozilla.com -i ~/mozilla_id_rsa'
pushing to ssh://hg.mozilla.org/try/
remote: Permission denied (publickey,keyboard-interactive).
abort: no suitable response from remote hg!
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #15)
> (In reply to Vivien Nicolas (:vingtetun) from comment #14)
> > (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #12)
> > > @jliebar suggests this could go through try-server before landing.
> > > @vingtetun, @mounir, thought?
> > 
> > Tim do you have a Level 1 access ?
> > (http://www.mozilla.org/hacking/commit-access-policy/)
> 
> I do (bug 726492), but I've never use it and I got Error when I tried to
> push to try

Please re-open your L1 access bug, or ping someone in #it.  In the meantime, I'll push this to try for you.
https://tbpl.mozilla.org/?tree=Try&rev=56f4f21a083a
Attachment #630842 - Attachment is obsolete: true
Comment on attachment 630847 [details] [diff] [review]
Patch to commit

Test failures on try (all platforms): https://tbpl.mozilla.org/php/getParsedLog.php?id=12452334&tree=Try
Attachment #630847 - Flags: review-
(In reply to Justin Lebar [:jlebar] from comment #18)
> Comment on attachment 630847 [details] [diff] [review]
> Patch to commit
> 
> Test failures on try (all platforms):
> https://tbpl.mozilla.org/php/getParsedLog.php?id=12452334&tree=Try

I have pushed a new version on https://tbpl.mozilla.org/?tree=Try&rev=705f6780206a

I bet nbEvents should be whitelistedEvents.length * 3 instead of an hardcoded number.
(In reply to Vivien Nicolas (:vingtetun) from comment #19)
> (In reply to Justin Lebar [:jlebar] from comment #18)
> > Comment on attachment 630847 [details] [diff] [review]
> > Patch to commit
> > 
> > Test failures on try (all platforms):
> > https://tbpl.mozilla.org/php/getParsedLog.php?id=12452334&tree=Try
> 
> I have pushed a new version on
> https://tbpl.mozilla.org/?tree=Try&rev=705f6780206a
> 
> I bet nbEvents should be whitelistedEvents.length * 3 instead of an
> hardcoded number.

After a few typos this one sounds green: https://tbpl.mozilla.org/?tree=Try&rev=bef95aa45b44 (still need to run a little thought...)
Created attachment 631911 [details] [diff] [review]
Patch v0.2
Attachment #630847 - Attachment is obsolete: true
Attachment #631911 - Flags: review?(justin.lebar+bug)
Attachment #631911 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6321d945bf2
https://hg.mozilla.org/mozilla-central/rev/a6321d945bf2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
@vingtetun Thanks.
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.