762403 - Disable the chrome debugger menu item until it's ready

Status: RESOLVED FIXED

Description

[Panos Astithas (he/him) [:past] (please ni?)]

It looks like getting all the pieces for chrome debugging will take a while. We should stop misleading users until that time, by hiding the "Browser Debugger" menu item.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Created attachment 630902 [details] [diff] [review]
Patch

Chrome debugging requires remote debugging by definition, so I added a dependency to the remote flag. When we have chrome debugging working, we can flip the chrome-enabled pref from then on and users can control it from the standard in our developer tools devtools.chrome.enabled pref.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/f6df0a1573e5

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f6df0a1573e5

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 630902 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature.
User impact if declined: Users will have access to a feature that is not ready yet.
Testing completed (on m-c, etc.): ON m-c.
Risk to taking this patch (and alternatives if risky): Riskier not to take it.
String or UUID changes made by this patch: none, but we did add a pref to firefox.js:

+pref("devtools.debugger.chrome-enabled", false);

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 630902 [details] [diff] [review]
Patch

[Triage Comment]
Approved for Aurora 15 - are you aware of anywhere this has been communicated and may need to be corrected? I know this wasn't noted for release notes.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/184b0179fb90

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Alex Keybl [:akeybl] from comment #5)
> Approved for Aurora 15 - are you aware of anywhere this has been
> communicated and may need to be corrected? I know this wasn't noted for
> release notes.

I believe this has only been discussed internally so far (including work weeks and weekly calls).

Comment 8

[Rob Campbell [:rc] (:robcee)]

(In reply to Panos Astithas [:past] from comment #7)
> (In reply to Alex Keybl [:akeybl] from comment #5)
> > Approved for Aurora 15 - are you aware of anywhere this has been
> > communicated and may need to be corrected? I know this wasn't noted for
> > release notes.
> 
> I believe this has only been discussed internally so far (including work
> weeks and weekly calls).

also, I don't think the addition of the Chrome Debugger was widely advertised to begin with. We plan on enabling it as a feature in a future version so it's probably not really relnote-worthy.

thanks Alex!

Comment 9

[Ioana (away)]

I am verifying this fix on Firefox 15.0 beta 3 but I need some clarifications: after setting devtools.chrome.enabled to true, should there be any visible effect on the debugger? How does the user start debugging chrome?

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Ioana Budnar [QA] from comment #9)
> I am verifying this fix on Firefox 15.0 beta 3 but I need some
> clarifications: after setting devtools.chrome.enabled to true, should there
> be any visible effect on the debugger?

Nope.

> How does the user start debugging chrome?

Chrome debugging is not implemented yet.

Comment 11

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0