__lookup{Getter,Setter}__ broken for proxies

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I need them to work for SpecialPowers wrapping stuff. Patch coming up.
Created attachment 630917 [details] [diff] [review]
Handle proxies on __lookupGetter__ and __lookupSetter__. v1

Attaching a patch. Flagging jorendorff for review.
Attachment #630917 - Flags: review?(jorendorff)
Depends on: 762492
Comment on attachment 630917 [details] [diff] [review]
Handle proxies on __lookupGetter__ and __lookupSetter__. v1

Heh. Gross, but I think it'll work.
Attachment #630917 - Flags: review?(jorendorff) → review+
Comment on attachment 630917 [details] [diff] [review]
Handle proxies on __lookupGetter__ and __lookupSetter__. v1

Whoops. Sorry, this needs a test. Re-request review please.
Attachment #630917 - Flags: review+
Created attachment 631330 [details] [diff] [review]
Handle proxies on __lookupGetter__ and __lookupSetter__. v2

To be fair, the patch already had tests in two places. But I understand the convenience of having js tests not depend on gecko. Reflagging.
Attachment #630917 - Attachment is obsolete: true
Attachment #631330 - Flags: review?(jorendorff)
Comment on attachment 631330 [details] [diff] [review]
Handle proxies on __lookupGetter__ and __lookupSetter__. v2

I'm really sorry, Bobby. I don't know how I missed the tests already in the patch. Just failed to scroll down or something.

Thanks for the js-only test. It'll help.
Attachment #631330 - Flags: review?(jorendorff) → review+
Pushed to try, along with another patch: https://tbpl.mozilla.org/?tree=Try&rev=29d25bdd5cc2
Pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/1bdd81c4d926
Flags: in-testsuite+
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/1bdd81c4d926
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 762492
No longer depends on: 762492

Updated

5 years ago
Depends on: 764289
Depends on: 766430
You need to log in before you can comment on or make changes to this bug.