Closed Bug 762434 Opened 10 years ago Closed 10 years ago
Allow any element to be labelable
No description provided.
Attachment #630919 - Flags: review?(bzbarsky)
Comment on attachment 630919 [details] [diff] [review] Patch GetFirstDescendantFormControl should probably be renamed to GetFirstLabelableDescendant. r=me with that.
Attachment #630919 - Flags: review?(bzbarsky) → review+
Target Milestone: --- → mozilla16
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 630919 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): none User impact if declined: bug fixed by bug 762435 will stay around for 3 months Risk to taking this patch (and alternatives if risky): this patch alone is pretty safe, it is only moving some logic from a class to another. String or UUID changes made by this patch: mozilla::dom::Element UUID change
Attachment #630919 - Flags: approval-mozilla-aurora?
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #3) > String or UUID changes made by this patch: mozilla::dom::Element UUID change We typically do not take UUID changes unless we're very confident that there will be no add-on compat or web compat breakage. Can you confirm?
There should be no web compat issues from the IID change. Addons are tougher, but QueryInterface to Element _should_ be pretty rare. It's a reasonably new class and most ways of getting one do not involve QueryInterface.
Comment on attachment 630919 [details] [diff] [review] Patch Thanks bz, approving in that case.
Attachment #630919 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed in aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/0e385bd36e31
Target Milestone: mozilla16 → mozilla15
You need to log in before you can comment on or make changes to this bug.