Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Allow any element to be labelable

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 630919 [details] [diff] [review]
Patch
Attachment #630919 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Blocks: 762435

Comment 1

5 years ago
Comment on attachment 630919 [details] [diff] [review]
Patch

GetFirstDescendantFormControl should probably be renamed to GetFirstLabelableDescendant.

r=me with that.
Attachment #630919 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

5 years ago
Flags: in-testsuite-
Target Milestone: --- → mozilla16
(Assignee)

Updated

5 years ago
Attachment #630919 - Flags: checkin+

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fab542b4877f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

5 years ago
Comment on attachment 630919 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: bug fixed by bug 762435 will stay around for 3 months
Risk to taking this patch (and alternatives if risky): this patch alone is pretty safe, it is only moving some logic from a class to another.
String or UUID changes made by this patch: mozilla::dom::Element UUID change
Attachment #630919 - Flags: approval-mozilla-aurora?

Comment 4

5 years ago
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #3)
> String or UUID changes made by this patch: mozilla::dom::Element UUID change

We typically do not take UUID changes unless we're very confident that there will be no add-on compat or web compat breakage. Can you confirm?

Comment 5

5 years ago
There should be no web compat issues from the IID change.

Addons are tougher, but QueryInterface to Element _should_ be pretty rare.  It's a reasonably new class and most ways of getting one do not involve QueryInterface.
Comment on attachment 630919 [details] [diff] [review]
Patch

Thanks bz, approving in that case.
Attachment #630919 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

5 years ago
Pushed in aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/0e385bd36e31
Target Milestone: mozilla16 → mozilla15
You need to log in before you can comment on or make changes to this bug.