762454 - File filtering "@" operator doesn't search for functions

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Kevin Dangoor]

1. open http://addyosmani.github.com/todomvc/architecture-examples/backbone/index.html
2. Type "todos@toggleDon" (don't add the "e", because of bug 762452)
3. it jumps to       "click .check"              : "toggleDone",

Expected result:

should jump to toggleDone: function()

Sublime Text uses @ to jump to functions and # to do a string search. The current behavior is equivalent to Sublime's #.

My suggestion is that we:

1. use "#" for the current behavior, right away
2. use "@" to search for functions, in a followup if need be

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

I think that's a good suggestion. I don't use "#" that much in Sublime, which is why it didn't occur to me earlier. Note that hitting Enter will move to the next match and start from scratch when it reaches the end.

Comment 2

[Kevin Dangoor]

(In reply to Panos Astithas [:past] from comment #1)
> I think that's a good suggestion. I don't use "#" that much in Sublime,
> which is why it didn't occur to me earlier. Note that hitting Enter will
> move to the next match and start from scratch when it reaches the end.

Cool. Somehow I had missed that.

If we could get a switch to # into Aurora, I think that would be preferable to changing the behavior later.

Comment 3

[Victor Porof [:vporof][:vp]]

Let's do a quick switch to #, and tackle the @function search in a followup?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof from comment #3)
> Let's do a quick switch to #, and tackle the @function search in a followup?

Agreed.

Comment 5

[Victor Porof [:vporof][:vp]]

Filed bug 762454.

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Victor Porof from comment #5)
> Filed bug 762454.

err.. bug 762825.

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/b1338c3c89b2

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b1338c3c89b2

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 631311 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: Users won't be able to search for functions.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): Negligible.
String or UUID changes made by this patch:

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b1094da581a6