Closed Bug 762454 Opened 10 years ago Closed 10 years ago
File filtering "@" operator doesn't search for functions
1. open http://addyosmani.github.com/todomvc/architecture-examples/backbone/index.html 2. Type "todos@toggleDon" (don't add the "e", because of bug 762452) 3. it jumps to "click .check" : "toggleDone", Expected result: should jump to toggleDone: function() Sublime Text uses @ to jump to functions and # to do a string search. The current behavior is equivalent to Sublime's #. My suggestion is that we: 1. use "#" for the current behavior, right away 2. use "@" to search for functions, in a followup if need be
I think that's a good suggestion. I don't use "#" that much in Sublime, which is why it didn't occur to me earlier. Note that hitting Enter will move to the next match and start from scratch when it reaches the end.
(In reply to Panos Astithas [:past] from comment #1) > I think that's a good suggestion. I don't use "#" that much in Sublime, > which is why it didn't occur to me earlier. Note that hitting Enter will > move to the next match and start from scratch when it reaches the end. Cool. Somehow I had missed that. If we could get a switch to # into Aurora, I think that would be preferable to changing the behavior later.
Let's do a quick switch to #, and tackle the @function search in a followup?
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
(In reply to Victor Porof from comment #3) > Let's do a quick switch to #, and tackle the @function search in a followup? Agreed.
Filed bug 762454.
Attachment #631311 - Flags: review?(past) → review+
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 631311 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): New feature User impact if declined: Users won't be able to search for functions. Testing completed (on m-c, etc.): on m-c. Risk to taking this patch (and alternatives if risky): Negligible. String or UUID changes made by this patch:
Attachment #631311 - Flags: approval-mozilla-aurora?
Attachment #631311 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.