Closed
Bug 762454
Opened 10 years ago
Closed 10 years ago
File filtering "@" operator doesn't search for functions
Categories
(DevTools :: Debugger, defect, P2)
Tracking
(firefox15 fixed)
RESOLVED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox15 | --- | fixed |
People
(Reporter: dangoor, Assigned: vporof)
References
()
Details
Attachments
(1 file)
3.65 KB,
patch
|
past
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1. open http://addyosmani.github.com/todomvc/architecture-examples/backbone/index.html 2. Type "todos@toggleDon" (don't add the "e", because of bug 762452) 3. it jumps to "click .check" : "toggleDone", Expected result: should jump to toggleDone: function() Sublime Text uses @ to jump to functions and # to do a string search. The current behavior is equivalent to Sublime's #. My suggestion is that we: 1. use "#" for the current behavior, right away 2. use "@" to search for functions, in a followup if need be
Comment 1•10 years ago
|
||
I think that's a good suggestion. I don't use "#" that much in Sublime, which is why it didn't occur to me earlier. Note that hitting Enter will move to the next match and start from scratch when it reaches the end.
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Panos Astithas [:past] from comment #1) > I think that's a good suggestion. I don't use "#" that much in Sublime, > which is why it didn't occur to me earlier. Note that hitting Enter will > move to the next match and start from scratch when it reaches the end. Cool. Somehow I had missed that. If we could get a switch to # into Aurora, I think that would be preferable to changing the behavior later.
Assignee | ||
Comment 3•10 years ago
|
||
Let's do a quick switch to #, and tackle the @function search in a followup?
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Comment 4•10 years ago
|
||
(In reply to Victor Porof from comment #3) > Let's do a quick switch to #, and tackle the @function search in a followup? Agreed.
Assignee | ||
Comment 5•10 years ago
|
||
Filed bug 762454.
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Victor Porof from comment #5) > Filed bug 762454. err.. bug 762825.
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #631311 -
Flags: review?(past)
Updated•10 years ago
|
Attachment #631311 -
Flags: review?(past) → review+
Updated•10 years ago
|
Whiteboard: [land-in-fx-team]
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b1338c3c89b2
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b1338c3c89b2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Updated•10 years ago
|
tracking-firefox15:
--- → ?
Comment 10•10 years ago
|
||
Comment on attachment 631311 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): New feature User impact if declined: Users won't be able to search for functions. Testing completed (on m-c, etc.): on m-c. Risk to taking this patch (and alternatives if risky): Negligible. String or UUID changes made by this patch:
Attachment #631311 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #631311 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b1094da581a6
status-firefox15:
--- → fixed
Updated•10 years ago
|
tracking-firefox15:
? → ---
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•