Note: There are a few cases of duplicates in user autocompletion which are being worked on.

File filtering "@" operator doesn't search for functions

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Kevin Dangoor, Assigned: vporof)

Tracking

14 Branch
Firefox 16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
1. open http://addyosmani.github.com/todomvc/architecture-examples/backbone/index.html
2. Type "todos@toggleDon" (don't add the "e", because of bug 762452)
3. it jumps to       "click .check"              : "toggleDone",

Expected result:

should jump to toggleDone: function()

Sublime Text uses @ to jump to functions and # to do a string search. The current behavior is equivalent to Sublime's #.

My suggestion is that we:

1. use "#" for the current behavior, right away
2. use "@" to search for functions, in a followup if need be
I think that's a good suggestion. I don't use "#" that much in Sublime, which is why it didn't occur to me earlier. Note that hitting Enter will move to the next match and start from scratch when it reaches the end.
(Reporter)

Comment 2

5 years ago
(In reply to Panos Astithas [:past] from comment #1)
> I think that's a good suggestion. I don't use "#" that much in Sublime,
> which is why it didn't occur to me earlier. Note that hitting Enter will
> move to the next match and start from scratch when it reaches the end.

Cool. Somehow I had missed that.

If we could get a switch to # into Aurora, I think that would be preferable to changing the behavior later.
(Assignee)

Comment 3

5 years ago
Let's do a quick switch to #, and tackle the @function search in a followup?
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
(In reply to Victor Porof from comment #3)
> Let's do a quick switch to #, and tackle the @function search in a followup?

Agreed.
(Assignee)

Comment 5

5 years ago
Filed bug 762454.
(Assignee)

Comment 6

5 years ago
(In reply to Victor Porof from comment #5)
> Filed bug 762454.

err.. bug 762825.
(Assignee)

Comment 7

5 years ago
Created attachment 631311 [details] [diff] [review]
v1
Attachment #631311 - Flags: review?(past)
Attachment #631311 - Flags: review?(past) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/b1338c3c89b2
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b1338c3c89b2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
tracking-firefox15: --- → ?
Comment on attachment 631311 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: Users won't be able to search for functions.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): Negligible.
String or UUID changes made by this patch:
Attachment #631311 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #631311 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b1094da581a6
status-firefox15: --- → fixed
tracking-firefox15: ? → ---
You need to log in before you can comment on or make changes to this bug.