If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[shipping] update defaults for multi-locale json

RESOLVED FIXED in 2.2

Status

Webtools
Elmo
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Pike, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The defaults for mobile are awful, let's update them to repo being releases/mozilla-beta, platform being android,android-xul, multi being android-multilocale, and path being mobile/android/locales/maemo-locales.

Those are in https://github.com/mozilla/elmo/blob/develop/apps/shipping/templates/shipping/confirm-ship.html
(Assignee)

Comment 1

5 years ago
The default platform should be just 'android', as we aren't building single locale repacks for android-xul.
(Assignee)

Comment 2

5 years ago
Created attachment 632759 [details] [diff] [review]
elmo diff

If you strongly prefer a pull request I can do that.
Attachment #632759 - Flags: review?(l10n)
(Reporter)

Comment 3

5 years ago
Comment on attachment 632759 [details] [diff] [review]
elmo diff

Review of attachment 632759 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, we work with patches in bugzilla for most of our stuff. I'm still a gecko guy, not a webdev :-)

Thanks for the patch, I'll land that tomorrow.
Attachment #632759 - Flags: review?(l10n) → review+

Comment 4

5 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/576fb4c9a61f6060c8e00c4dcb103e0d2f835c2f
bug 762531, update defaults for mobile l10n-changesets.json, r=Pike
(Reporter)

Comment 5

5 years ago
Marking FIXED. This should go into production next monday, in time for the next go-to-build.
Assignee: nobody → aki
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2
(Reporter)

Comment 6

5 years ago
That's in production now, too.
You need to log in before you can comment on or make changes to this bug.