The default bug view has changed. See this FAQ.

Attachment is attached to old (one previous) comment by email_in script

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Incoming Email
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: himorin, Assigned: himorin)

Tracking

4.3.1
Bugzilla 4.2
Bug Flags:
approval +
approval4.2 +

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 631280 [details] [diff] [review]
patch v.1

Since &process_bug returns the last comment object from old Bugzilla::Bug->check object, attachment will be considered to one for 'previous' comment than the actual new comment added via email_in script.
process_bug should renew Bugzilla::Bug object before getting latest comment object from it.
Attachment #631280 - Flags: review?

Updated

5 years ago
Attachment #631280 - Flags: review? → review?(LpSolit)

Comment 1

5 years ago
Comment on attachment 631280 [details] [diff] [review]
patch v.1

Looks good and works fine. A comment should be added explaining why we recreate the bug object instead of reusing the existing one. This can be done on checkin. r=LpSolit
Attachment #631280 - Flags: review?(LpSolit) → review+

Updated

5 years ago
Assignee: incoming.email → shimono
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: approval4.2+
Flags: approval+
Target Milestone: --- → Bugzilla 4.2

Comment 2

5 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified email_in.pl
Committed revision 8267.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified email_in.pl
Committed revision 8097.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.