Closed Bug 762785 Opened 11 years ago Closed 11 years ago

Attachment is attached to old (one previous) comment by email_in script

Categories

(Bugzilla :: Incoming Email, defect)

Product:
Bugzilla
Component:
Incoming Email
Version:
4.3.1
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.2

People

(Reporter: himorin, Assigned: himorin)

Details

Attachments

(1 file)

patch v.1
399 bytes, patch
LpSolit
: review+
Details | Diff | Splinter Review
Attached patch patch v.1 — — Splinter Review 
Since &process_bug returns the last comment object from old Bugzilla::Bug->check object, attachment will be considered to one for 'previous' comment than the actual new comment added via email_in script.
process_bug should renew Bugzilla::Bug object before getting latest comment object from it.
Attachment #631280 - Flags: review?
Attachment #631280 - Flags: review? → review?(LpSolit)
Comment on attachment 631280 [details] [diff] [review]
patch v.1

Looks good and works fine. A comment should be added explaining why we recreate the bug object instead of reusing the existing one. This can be done on checkin. r=LpSolit
Attachment #631280 - Flags: review?(LpSolit) → review+
Assignee: incoming.email → shimono
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: approval4.2+
Flags: approval+
Target Milestone: --- → Bugzilla 4.2
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified email_in.pl
Committed revision 8267.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified email_in.pl
Committed revision 8097.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.