Last Comment Bug 762785 - Attachment is attached to old (one previous) comment by email_in script
: Attachment is attached to old (one previous) comment by email_in script
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Incoming Email (show other bugs)
: 4.3.1
: All All
: -- minor (vote)
: Bugzilla 4.2
Assigned To: A. Shimono [:himorin]
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-07 23:13 PDT by A. Shimono [:himorin]
Modified: 2012-06-20 15:22 PDT (History)
0 users
LpSolit: approval+
LpSolit: approval4.2+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v.1 (399 bytes, patch)
2012-06-07 23:13 PDT, A. Shimono [:himorin]
LpSolit: review+
Details | Diff | Splinter Review

Description A. Shimono [:himorin] 2012-06-07 23:13:05 PDT
Created attachment 631280 [details] [diff] [review]
patch v.1

Since &process_bug returns the last comment object from old Bugzilla::Bug->check object, attachment will be considered to one for 'previous' comment than the actual new comment added via email_in script.
process_bug should renew Bugzilla::Bug object before getting latest comment object from it.
Comment 1 Frédéric Buclin 2012-06-20 15:10:16 PDT
Comment on attachment 631280 [details] [diff] [review]
patch v.1

Looks good and works fine. A comment should be added explaining why we recreate the bug object instead of reusing the existing one. This can be done on checkin. r=LpSolit
Comment 2 Frédéric Buclin 2012-06-20 15:22:04 PDT
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified email_in.pl
Committed revision 8267.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified email_in.pl
Committed revision 8097.

Note You need to log in before you can comment on or make changes to this bug.