762787 - Reduce CGI_URI_LIMIT from 8000 to 2083 when using Internet Explorer

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

bug 513989 introduced CGI_URI_LIMIT set at 8000 to protect against 414 errors.
8000 was used as it falls just under apache httpd's default max uri length.

unfortunately internet explorer does not support urls that have more than 2083 characters (see http://support.microsoft.com/kb/208427).

we should change CGI_URI_LIMIT to 2083

Comment 1

[Simon Green]

Attachment: v1 patch

Included a patch to move this along :)

  -- simon

Comment 2

[Frédéric Buclin]

Comment on attachment 632066 [details] [diff] [review]
v1 patch

>-use constant CGI_URI_LIMIT => 8000;
>+# See http://support.microsoft.com/kb/208427
>+use constant CGI_URI_LIMIT => 2083;

I see no reason to reduce this limit for all browsers because IE sucks. We should keep 8000 unless IE is explicitly detected. Something like:

  use constant CGI_URI_LIMIT => $ENV{'HTTP_USER_AGENT'} =~ /foo/ ? 2083 : 8000;

Comment 3

[Simon Green]

Attachment: v2 patch

Now with recommended changes.

Comment 4

[:glob ✱]

Comment on attachment 632074 [details] [diff] [review]
v2 patch

r=glob

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Constants.pm
Committed revision 8275.

Comment 6

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Constants.pm
Committed revision 8276.