Closed Bug 762799 Opened 11 years ago Closed 11 years ago

Cannot open bookmark from sidebar with keyboard (with Enter key)

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Version:
14 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox14 + fixed
firefox15 + verified
firefox16 + fixed

People

(Reporter: starcas25, Assigned: asaf)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

patch
1.12 KB, patch
mak
: review+
Gavin
: approval-mozilla-aurora+
Gavin
: approval-mozilla-beta+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0
Build ID: 20120605113340

Steps to reproduce:

Start (fx14 beta) with a new, blank user profile.
Hit Ctrl+B to open Bookmarks Sidebar.
Select any bookmark using keyboard, eg, the 'Help and Tutorials' bookmark.
Hit Enter to open the bookmark.


Actual results:

Nothing happens.

Checked the Error Console:
Error: TypeError: aView is null
Source File: resource:///modules/PlacesUIUtils.jsm
Line: 655


Expected results:

Bookmark should open page in main window.
Blocks: 739451
Status: UNCONFIRMED → NEW
Component: Untriaged → Bookmarks & History
Ever confirmed: true
Keywords: regression
QA Contact: untriaged → bookmarks
This is regressed by bug 739451
Keywords: regressionwindow-wanted
Assignee: nobody → mano
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #637597 -
        Flags: review?(mak77)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #637597 -
        Attachment is obsolete: true

        Attachment #637597 -
        Flags: review?(mak77)

        Attachment #637606 -
        Flags: review?(mak77)

    
    

    
  
Comment on attachment 637606 [details] [diff] [review]
patch

Review of attachment 637606 [details] [diff] [review]:
-----------------------------------------------------------------

minimal change, like it.
I also like the fact we just undisclosed a bug that was already there but covered by our previous workaround.

        Attachment #637606 -
        Flags: review?(mak77) → review+

    
    

    
  
Comment on attachment 637606 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): frontend-fixes for cpg (bug 739451) which are not backoutable
User impact if declined: Summary says it all.
Testing completed (on m-c, etc.): there are no test for this functionality. I'll open a follow for that.
Risk to taking this patch (and alternatives if risky): No alternatives, but this should be very safe.
String or UUID changes made by this patch: none.

        Attachment #637606 -
        Flags: approval-mozilla-beta?

        Attachment #637606 -
        Flags: approval-mozilla-aurora?
OS: Windows XP → All
Hardware: x86 → All

    
    

    
  
Comment on attachment 637606 [details] [diff] [review]
patch

Yeah, let's get some testing for this in a followup! Please land ASAP

        Attachment #637606 -
        Flags: approval-mozilla-beta?

        Attachment #637606 -
        Flags: approval-mozilla-beta+

        Attachment #637606 -
        Flags: approval-mozilla-aurora?

        Attachment #637606 -
        Flags: approval-mozilla-aurora+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6fd744aca078
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16

    
    

    
  
Verified on Firefox 15 beta 3 that the bookmarks can be opened from the sidebar using the keyboard (with Enter key). 

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.6:

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0

          status-firefox15:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.