762799 - Cannot open bookmark from sidebar with keyboard (with Enter key)

Status: RESOLVED FIXED

Description

[Rick]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0
Build ID: 20120605113340

Steps to reproduce:

Start (fx14 beta) with a new, blank user profile.
Hit Ctrl+B to open Bookmarks Sidebar.
Select any bookmark using keyboard, eg, the 'Help and Tutorials' bookmark.
Hit Enter to open the bookmark.


Actual results:

Nothing happens.

Checked the Error Console:
Error: TypeError: aView is null
Source File: resource:///modules/PlacesUIUtils.jsm
Line: 655


Expected results:

Bookmark should open page in main window.

Comment 1

[Alice0775 White]

This is regressed by bug 739451

Comment 2

[Alice0775 White]

Pushlog
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4ea78fe84b7c&tochange=690e77288e98

Comment 3

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Created attachment 637597 [details] [diff] [review]
patch

Comment 4

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Created attachment 637606 [details] [diff] [review]
patch

Comment 5

[Marco Bonardo [::mak]]

Comment on attachment 637606 [details] [diff] [review]
patch

Review of attachment 637606 [details] [diff] [review]:
-----------------------------------------------------------------

minimal change, like it.
I also like the fact we just undisclosed a bug that was already there but covered by our previous workaround.

Comment 6

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6fd744aca078

I'll open a follow-up for tests.

Comment 7

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Comment on attachment 637606 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): frontend-fixes for cpg (bug 739451) which are not backoutable
User impact if declined: Summary says it all.
Testing completed (on m-c, etc.): there are no test for this functionality. I'll open a follow for that.
Risk to taking this patch (and alternatives if risky): No alternatives, but this should be very safe.
String or UUID changes made by this patch: none.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 637606 [details] [diff] [review]
patch

Yeah, let's get some testing for this in a followup! Please land ASAP

Comment 9

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/c4dac534629c

Comment 10

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

http://hg.mozilla.org/releases/mozilla-beta/rev/48bbc196e9a3

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6fd744aca078

Comment 12

[Simona Badau [Away. Please needinfo? Alin Deac [:alindeac]]]

Verified on Firefox 15 beta 3 that the bookmarks can be opened from the sidebar using the keyboard (with Enter key). 

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.6:

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0