Cannot open bookmark from sidebar with keyboard (with Enter key)
RESOLVED
FIXED
in Firefox 14
Status
()
People
(Reporter: starcas25, Assigned: mano)
Tracking
({regression})
Firefox Tracking Flags
(firefox14+ fixed, firefox15+ verified, firefox16+ fixed)
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
1.12 KB,
patch
|
mak
:
review+
Gavin
:
approval-mozilla-aurora+
Gavin
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0 Build ID: 20120605113340 Steps to reproduce: Start (fx14 beta) with a new, blank user profile. Hit Ctrl+B to open Bookmarks Sidebar. Select any bookmark using keyboard, eg, the 'Help and Tutorials' bookmark. Hit Enter to open the bookmark. Actual results: Nothing happens. Checked the Error Console: Error: TypeError: aView is null Source File: resource:///modules/PlacesUIUtils.jsm Line: 655 Expected results: Bookmark should open page in main window.
|
||
Updated•7 years ago
|
Blocks: 739451
Status: UNCONFIRMED → NEW
Component: Untriaged → Bookmarks & History
Ever confirmed: true
Keywords: regression
QA Contact: untriaged → bookmarks
|
|
||
Updated•7 years ago
|
tracking-firefox14: --- → ?
tracking-firefox15: --- → ?
tracking-firefox16: --- → ?
|
||
Updated•7 years ago
|
tracking-firefox14: ? → +
tracking-firefox15: ? → +
tracking-firefox16: ? → +
Keywords: qawanted, regressionwindow-wanted
|
|
||
Comment 2•7 years ago
|
||
Pushlog http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4ea78fe84b7c&tochange=690e77288e98
|
||
Updated•7 years ago
|
Assignee: nobody → mano
|
|
||
Updated•7 years ago
|
Keywords: qawanted
|
(Assignee) | |
Comment 3•7 years ago
|
||
Created attachment 637597 [details] [diff] [review] patch
Attachment #637597 -
Flags: review?(mak77)
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Created attachment 637606 [details] [diff] [review] patch
Attachment #637597 -
Attachment is obsolete: true
Attachment #637597 -
Flags: review?(mak77)
Attachment #637606 -
Flags: review?(mak77)
|
||
Comment 5•7 years ago
|
||
Comment on attachment 637606 [details] [diff] [review] patch Review of attachment 637606 [details] [diff] [review]: ----------------------------------------------------------------- minimal change, like it. I also like the fact we just undisclosed a bug that was already there but covered by our previous workaround.
Attachment #637606 -
Flags: review?(mak77) → review+
|
|
(Assignee) | |
Comment 6•7 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/6fd744aca078 I'll open a follow-up for tests.
|
|
(Assignee) | |
Comment 7•7 years ago
|
||
Comment on attachment 637606 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): frontend-fixes for cpg (bug 739451) which are not backoutable User impact if declined: Summary says it all. Testing completed (on m-c, etc.): there are no test for this functionality. I'll open a follow for that. Risk to taking this patch (and alternatives if risky): No alternatives, but this should be very safe. String or UUID changes made by this patch: none.
Attachment #637606 -
Flags: approval-mozilla-beta?
Attachment #637606 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•7 years ago
|
OS: Windows XP → All
Hardware: x86 → All
|
|
||
Comment 8•7 years ago
|
||
Comment on attachment 637606 [details] [diff] [review] patch Yeah, let's get some testing for this in a followup! Please land ASAP
Attachment #637606 -
Flags: approval-mozilla-beta?
Attachment #637606 -
Flags: approval-mozilla-beta+
Attachment #637606 -
Flags: approval-mozilla-aurora?
Attachment #637606 -
Flags: approval-mozilla-aurora+
|
|
(Assignee) | |
Comment 9•7 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/c4dac534629c
status-firefox15: --- → fixed
|
|
(Assignee) | |
Comment 10•7 years ago
|
||
http://hg.mozilla.org/releases/mozilla-beta/rev/48bbc196e9a3
status-firefox14: --- → fixed
|
||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6fd744aca078
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
|
||
Updated•7 years ago
|
status-firefox16: --- → fixed
Verified on Firefox 15 beta 3 that the bookmarks can be opened from the sidebar using the keyboard (with Enter key). Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.6: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0 Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0
status-firefox15: fixed → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•