762812 - Elements cut off in preferences dialog for es-AR locale

Status: RESOLVED FIXED

(Mozilla Localizations :: es-AR / Spanish (Argentina), defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot 1

Our Mozmill l10n tests have been shown that there are some elements which are cut off in the preferences dialog. The full list of those elements you can find here:

http://mozmill-crowd.blargon7.com/#/l10n/report/87961186c2b807b7747aa7e6d4071c24

Details:

 Node is cut off by 94 px at the right: tabbox#advancedPrefs. Parent node: vbox[xbl:inherits=flex][class=content-box]

This probably also applies to Firefox 14 which is in beta now.

I haven't ran the tests on Linux or Windows. So at least OS X is affected by it.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot 2

Comment 2

[Marcelo Poli]

Attachment: Linux screenshot

Seems that a long string is multiline in Linux and it's single line in OS X.
I don't want to widen the dialog just for one string.
Also, it's hard to shorten the string.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't think that this is the only problem here. The strings in this pane are a bit longer in general and push the buttons out of the view box. Given that users are nearly unable to click on those buttons to open sub windows. So you should really widen the dialog a bit on OS X only.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Can we get an update on this bug? Its causing failures each time you check-in a change. Thanks!

Comment 5

[Marcelo Poli]

Size fixed and tested.


http://hg.mozilla.org/l10n-central/es-AR/rev/a3e8cbf4a1c8
http://hg.mozilla.org/releases/l10n/mozilla-beta/es-AR/rev/fd59c946f303
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-AR/rev/803b9537d012

If you find that everything is ok, you may close this bug.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Marcelo. One question I still have. The screenshot you have attached for Linux also shows cut-off pixels on the right side. The changesets you have referenced don't have an update for Linux. Have you fixed that in another patch?

Comment 7

[Marcelo Poli]

(In reply to Henrik Skupin (:whimboo) from comment #6)
> Thanks Marcelo. One question I still have. The screenshot you have attached
> for Linux also shows cut-off pixels on the right side. The changesets you
> have referenced don't have an update for Linux. Have you fixed that in
> another patch?

Oops, I missed that.
I didn't realize that the frame was missing some pixels as the text and buttons were shown.
I'll fix it ASAP.

Comment 8

[Marcelo Poli]

Obsolete with new preferences tab.