Closed Bug 76291 Opened 23 years ago Closed 23 years ago

(ftp: or file:) url spews many blank browser windows

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: dougt)

References

Details

(Keywords: regression, smoketest)

Attachments

(1 file)

Fixes problem. v1
3.03 KB, patch
Details | Diff | Splinter Review 
not sure if this is the right component --found this on a 7:15pm-ish debug build
on linux. basically, if i try to open an ftp url from either the URL bar or the
Open Web Location dialog, mozilla opens up a bunch of blank browser
windows...indefinitely. (well, i hit ^C in the console to stop it. :)

to repro:
1. go to the URL bar --or, open the Open Web Location dialog-- and enter
ftp://ftp.mozilla.org/
2. hit enter.

*Important* clicking on a link with an ftp url will *not* exhibit this problem
[doing that works fine].

result: watch the windows open. get the following console errors each time a
window opened:

WEBSHELL+ = 6
WEBSHELL+ = 7
Enabling Quirk StyleSheet
JavaScript error: 
chrome://communicator/content/securityUI.js line 30:
Components.classes['@mozilla.org/secure_browser_ui;1'] has no properties
Error loading URL ftp://ftp.mozilla.org/ : 2152398850
WEBSHELL+ = 8

anyone else see this?
spoke w/jag --the console error above prolly isn't relevant, but i filed bug
76292 it.

anyhow, i'll check to see if this occurs with a verification build...
Keywords: nsbeta1, nsdogfood, regression
not a problem with the 2001.04.16.10 verification build.
*** Bug 76333 has been marked as a duplicate of this bug. ***
i wonder if we can get an extension on 0.9.. dupe was filed as smoketest 
blocker
Severity: critical → blocker
Keywords: smoketest
This doesn't seam limited to ftp URLs, I also see this if I enter a file:// URL
into the urlbar.

This is with 2001041621 on Linux.
This works for me on my own opt build from 2001-04-17, so it might have been fixed.
seen on commercial builds:

windows 2001-04-17-06-trunk
mac 2001-04-17-04-trunk
I see this on the pre-8AM win32 build from today - 2001-04-17-06-trunk
Spam URIloader/download folks.

I just saw this on a Mac build from 4am *yesterday*.  I ended up having to bail 
from the debugger.  It was awful!  I *think* I produced it by loading 
"thrify.com" (note: typo!)
OS: Linux → All
Hardware: PC → All
Summary: opening ftp url spews many blank browser windows → opening url spews many blank browser windows
rebuilding tree now.  since it is both ftp and file, this may be a directory
viewer problem.  Can anyone with a build from yesterday back out this change:

cvs update -j1.73 -j1.72 mozilla/xpfe/components/directory/nsDirectoryViewer.cpp
Status: NEW → ASSIGNED
I don't think its me - file:// urls don't go through nsDirectoryViewer.cpp. I'm
rebuilding now, but I patched nsCRT.h, so it'll be another half hour to an hour
or so.
I backed myself out and still see this.

When I try to open a file:// uri using the urlbar I get:

The link to file:/// was blocked by the security manager.
Remote content may not link to local content.
Error loading URL file:/// : 2152398850

on the console, (before the never-ending windows) which may be a separate bug,
but is definately wrong, and a smoketest blocker as well.

so I'm ccing mstoltz anyway, due to the security patches checked in yesterday :)
mail sent to hook.
FWIW, I see lots of errors (maybe one for each window) of:

Error loading URL file:///home/dbaron/webtest/ : 2152398850

where:
js> Number(2152398850).toString(16)
804b0002

and 0x804b0002 is (I think) NS_BINDING_ABORTED.
On a mac build from yesterday, I simply see a failure to load the FTP url:
Error loading URL ftp://ftp.mozilla.org/ : 2152398849
but no window spawning.

In classic skin, I get:

###!!! ASSERTION: Error scroll port has too many children: 'count <= 1', file 
nsScrollPortView.cpp, line 415
Error loading URL ftp://ftp.mozilla.org/ : 2152398850

I have a Windows build from yesterday which does not have the problem and a mac
build from today which does. Starting with the URILoader, I'll see where they
diverge.

    
    

    
  
I need a review.

    
    

    
  
r=valeski; thanks doug!

    
    

    
  
fix is in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 76377 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 76395 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 76473 has been marked as a duplicate of this bug. ***

    
    

    
  
verified fixed on commercial builds:

windows 2001-04-18-06-trunk
linux 2001-04-18-05-trunk

Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 76612 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 77409 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 76473 has been marked as a duplicate of this bug. ***

    
    

    
  
-> networking, changed summary for accuracy
Component: Networking: FTP → Networking
Summary: opening url spews many blank browser windows → (ftp: or file:) url spews many blank browser windows

    
    

    
  
*** Bug 77111 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: