763005 - can't update rules with balrog ui

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[[e-mail] (:bhearsum)]

I get an alert that says "data_version" when I try to.

On the server side I see this in the application log:
2012-06-08 11:59:57,545: AdminView.post: processing POST request to /rules/4
2012-06-08 11:59:57,547: AUSTable.select: Executing query: 'SELECT permissions.permission, permissions.username, permissions.options, permissions.data_version 
FROM permissions 
WHERE permissions.username = %s AND permissions.permission = %s'
2012-06-08 11:59:57,565: AUSTable.select: Executing query: 'SELECT rules.rule_id, rules.priority, rules.mapping, rules.throttle, rules.update_type, rules.product, rules.version, rules.channel, rules.`buildTarget`, rules.`buildID`, rules.locale, rules.`osVersion`, rules.distribution, rules.`distVersion`, rules.`headerArchitecture`, rules.comment, rules.data_version 
FROM rules 
WHERE rules.rule_id = %s'
2012-06-08 11:59:57,570: AUSTransaction.execute: Attempting to execute SELECT rules.rule_id, rules.priority, rules.mapping, rules.throttle, rules.update_type, rules.product, rules.version, rules.channel, rules.`buildTarget`, rules.`buildID`, rules.locale, rules.`osVersion`, rules.distribution, rules.`distVersion`, rules.`headerArchitecture`, rules.comment, rules.data_version 
FROM rules 
WHERE rules.rule_id = %s
2012-06-08 11:59:57,580: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,581: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,582: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,583: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,584: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,585: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,586: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,586: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,587: NullableTextField: No value list, setting self.data to None
2012-06-08 11:59:57,589: retry: Calling <bound method Releases.getReleaseNames of <auslib.db.Releases object at 0xb45392cc>> with args: (), kwargs: {}, attempt #1
2012-06-08 11:59:57,590: AUSTable.select: Executing query: 'SELECT releases.name 
FROM releases'
2012-06-08 11:59:57,617: AUSTransaction.__exit__: exc is:

Comment 1

[[e-mail] (:bhearsum)]

Looks like I broke it!
16:21 < erick> bhearsum: re: https://bugzil.la/763005 ... somewhere in our form updates we lost data_version 
               being included in form.hidden_tag()
16:21 < bhearsum> ahhhhhh
16:21 < erick> I'm not sure why yet
16:21 < bhearsum> sounds like i broke it....
16:22 < bhearsum> https://github.com/mozilla/balrog/commit/72c34307e32885150a2747dd5524cecb73c38519#diff-7 
                  looks likely
16:23 < erick> yeah, that would do it.

Comment 2

[[e-mail] (:bhearsum)]

Also noticed that deletes are broken, too. I get redirected to an URL like this:
https://aus4-admin-dev.allizom.org/user_permissions.html?rules-options=&rules-data_version=1&submit=

Comment 3

[Peter Bengtsson [:peterbe]]

No more alerts about missing 'data_version' as of this:

https://github.com/mozilla/balrog/pull/7

:bhearsum r?

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/afdbbbb252772acc40078a0a3c7a1c879fcf53a4
bug 763005 - ability to update rules, r=bhearsum

Comment 5

[[e-mail] (:bhearsum)]

(In reply to [github robot] from comment #4)
> Commit pushed to master at https://github.com/mozilla/balrog
> 
> https://github.com/mozilla/balrog/commit/
> afdbbbb252772acc40078a0a3c7a1c879fcf53a4
> bug 763005 - ability to update rules, r=bhearsum

Looks like we're done here. Thanks Peter!