Report telemetry data for if the MozillaMaintenance service is installed

RESOLVED FIXED in mozilla16

Status

()

Toolkit
Application Update
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

12 Branch
mozilla16
x86_64
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
We need to create a telemetry histogram for UPDATE_SERVICE_INSTALLED.  It should be a boolean histogram with values 0, 1 which correspond with whether or not the MozillaMaintenance service exists on the machine.
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla16
(Assignee)

Comment 1

6 years ago
This telemetry ping should only be sent from Windows machines.
(Assignee)

Comment 2

6 years ago
Created attachment 631603 [details] [diff] [review]
Patch v1 - Not yet tested
(Assignee)

Comment 3

6 years ago
Created attachment 631708 [details] [diff] [review]
Patch v2 -Tested
Attachment #631603 - Attachment is obsolete: true
Attachment #631708 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 4

6 years ago
After I wrote this patch I realized we have a registry entry for Installed with a DWORD value of 1 or 0.  But this patch may be more deterministic. But I'm open to changing it if you prefer to the reg way.
(Assignee)

Comment 5

6 years ago
Created attachment 633125 [details] [diff] [review]
Patch v3

After thinking about it more, our other checks use the Installed reg value already so we might as well stay consistent.  Doing  a reg check is cleaner than using ctypes anyway.

The code is probably fine either way but in theory the SCM can be locked and it might take longer to check via the SCM.

Also this value will always be in sync with whether or not the service is actually installed unless a user goes and modifies it themselves.
Attachment #633125 - Flags: review?(robert.bugzilla)
(Assignee)

Updated

6 years ago
Attachment #631708 - Attachment is obsolete: true
Attachment #631708 - Flags: review?(robert.bugzilla)
Attachment #633125 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/mozilla-central/rev/1e497edb48c1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 767471
You need to log in before you can comment on or make changes to this bug.