another small change to build scripts

RESOLVED FIXED

Status

SeaMonkey
Website
RESOLVED FIXED
6 years ago
a month ago

People

(Reporter: jakem, Assigned: InvisibleSmiley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #763060 +++

On top of the change in bug 763060, there's actually 2 more small path tweaks that would help us out a lot.

The short version is, 2 more lines in bin/build_full should be changed:

-rsync -a --delete dest/ /data/static/www/www.seamonkeyproject.org
+rsync -a --delete dest/ /data/static/src/www.seamonkeyproject.org

-ln -s /data/static/www/www.seamonkeyproject.org dest
+ln -s /data/static/src/www.seamonkeyproject.org dest

Let me know if/when you commit this... once you do, it'll stop auto-updating until I tweak the cron jobs a bit (described below).

Thanks!



Explanation:

Our newer admin nodes generally operate like this:
1) Site code is pulled down from the maintainer's repo into /data/<cluster>/src/<site>

2) Parts of the site (if any) are merged in- locales, local/environment settings, etc

3) The completed site is rsync'd from /data/<cluster>/src/<site> to /data/<cluster>/www/<site>, excluding source control directories... basically a clean copy

4) /data/<cluster>/www is a local git repo... everything is added and committed

5) The web nodes "git pull" this down... on command or on a schedule.


Presently, your build scripts write directly to the 'www' side of this, and there's a hack in place that every 10min we arbitrarily add/commit that directory.

The big problem (other than a bit of extra delay waiting for that global add/commit to come around) is that if anyone ever tries to deploy your site like a "normal" site (or just does a "./deploy --all"), the copy in www will be overwritten by whatever is in src... which is old data. Your regular update crons will eventually fix it, that could take as much as a full day depending on what's different.

So, the change should be changed to start writing to the "src" directory, and then I'll amend the crons to immediately call "deploy www.seamonkeyproject.org" after each cron. No commit delay, no chance of accidentally deploying old data.
(Assignee)

Comment 1

6 years ago
Checking in bin/build_full;
/www/seamonkeyproject-org/bin/build_full,v  <--  build_full
new revision: 1.4; previous revision: 1.3
done
Assignee: nobody → jh
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

6 years ago
Sorry, mean to note on this right after you posted... but we did indeed finish off the stuff from comment 0 shortly after you committed the changes. :)

Updated

a month ago
Product: Websites → SeaMonkey
You need to log in before you can comment on or make changes to this bug.