Closed Bug 763117 Opened 9 years ago Closed 9 years ago

The src input parameter of HASH_HashBuf should be const

Categories

(NSS :: Libraries, defect, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Proposed patch (obsolete) — Splinter Review
The 'src' input parameter of HASH_HashBuf should be const.

Bob, this change will affect the freebl (lib/freebl/rawhash.c)
implementation of HASH_HashBuf that you're adding in bug 475578.
Attachment #631579 - Flags: review?(rrelyea)
Comment on attachment 631579 [details] [diff] [review]
Proposed patch

r+ relyea
Attachment #631579 - Flags: review?(rrelyea) → review+
Also fixed the new HASH_HashBuf implementation in lib/freebl/rawhash.c.

Patch checked in on the NSS trunk (NSS 3.14).

Checking in lib/cryptohi/sechash.c;
/cvsroot/mozilla/security/nss/lib/cryptohi/sechash.c,v  <--  sechash.c
new revision: 1.14; previous revision: 1.13
done
Checking in lib/freebl/rawhash.c;
/cvsroot/mozilla/security/nss/lib/freebl/rawhash.c,v  <--  rawhash.c
new revision: 1.9; previous revision: 1.8
done
Checking in lib/freebl/sechash.h;
/cvsroot/mozilla/security/nss/lib/freebl/sechash.h,v  <--  sechash.h
new revision: 1.10; previous revision: 1.9
done
Attachment #631579 - Attachment is obsolete: true
Assignee: nobody → wtc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.