763139 - LivemarkService.createLivemark is reported as deprecated but not marked as deprecated.

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Christopher Finke]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/20100101 Firefox/13.0
Build ID: 20120601045813

Steps to reproduce:

Called LivemarkService.createLivemark from add-on code (see resource:///components/nsLivemarkService.js)


Actual results:

An error appeared in the Error Console:

Error: ark is deprecated and will be removed in a future release.  Check the nsILivemarkService interface.
Source File: resource:///components/nsLivemarkService.js
Line: 204


Expected results:

The function definition for createLivemark should read:

createLivemark: function DEPRECATED_LS_createLivemark

instead of 

createLivemark: function LS_createLivemark

so that the slice(14) in _reportDeprecatedMethod doesn't chop off the majority of the function name and so the error appears properly, like so:

Error: createLivemark is deprecated and will be removed in a future release.  Check the nsILivemarkService interface.
Source File: resource:///components/nsLivemarkService.js
Line: 204

Comment 1

[Marco Bonardo [:mak]]

Do you have the possibility/time to attach a patch for this?

Comment 2

[Christopher Finke]

Attachment: Adds the "DEPRECATED_" prefix to the LS_createLivemark function name

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 633008 [details] [diff] [review]
Adds the "DEPRECATED_" prefix to the LS_createLivemark function name

Review of attachment 633008 [details] [diff] [review]:
-----------------------------------------------------------------

Could you please follow the hints here, especially setting the user and the commit message:
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

then you can just attach the updated patch and add the checkin-needed keyword
Thank you!

::: toolkit/components/places/nsLivemarkService.js
@@ +252,1 @@
>                                               aFeedURI, aIndex)

the arguments should be reindented here, respecting the 80 chars limit, so

  createLivemark: function DEPRECATED_LS_createLivemark(aParentId, aTitle,
                                                        aSiteURI, aFeedURI,
                                                        aIndex)

Comment 4

[Christopher Finke]

Attachment: Adds the "DEPRECATED_" prefix to the LS_createLivemark function name to ensure that createLivemark appears untruncated in the console warning when used.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

The updated patch was busted. Fixed up and pushed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f68238e9c432

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f68238e9c432