763180 - NS_XRE_ENABLE_EXTENSION_MANAGER flag does nothing

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

Since bug 553169, the NS_XRE_ENABLE_EXTENSION_MANAGER flag in nsXREAppData is never checked. This means that not setting it *doesn't* disable the addon manager.
Either the flag should be removed, or we should fix this and disable the addon manager when the flag is set.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Best to just remove the flag, I think. 

I looked into disabling the Add-ons Manager recently (see bug 754915 comment 8) - it seems doable, but it would be a bunch of work to fix up other components that rely on it (not to mention trying to test those changes), without any clear major benefit.

Comment 2

[Mark Banner (:standard8) (afk until 20 July)]

Attachment: Remove NS_XRE_ENABLE_EXTENSION_MANAGER

Found this whilst looking at some Thunderbird issues, and if we should sync things or not. Its been gecko 1.9.2 since this was last used, so lets just drop it.

Comment 3

[Mark Banner (:standard8) (afk until 20 July)]

Try run here: https://tbpl.mozilla.org/?tree=Try&rev=136d2a60594b

Comment 4

[Mark Banner (:standard8) (afk until 20 July)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ce721baa271

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ce721baa271