Closed Bug 763180 Opened 10 years ago Closed 8 years ago

NS_XRE_ENABLE_EXTENSION_MANAGER flag does nothing

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: glandium, Assigned: standard8)

References

Details

Attachments

(1 file)

Remove NS_XRE_ENABLE_EXTENSION_MANAGER
4.24 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
Since bug 553169, the NS_XRE_ENABLE_EXTENSION_MANAGER flag in nsXREAppData is never checked. This means that not setting it *doesn't* disable the addon manager.
Either the flag should be removed, or we should fix this and disable the addon manager when the flag is set.
Best to just remove the flag, I think. 

I looked into disabling the Add-ons Manager recently (see bug 754915 comment 8) - it seems doable, but it would be a bunch of work to fix up other components that rely on it (not to mention trying to test those changes), without any clear major benefit.
Found this whilst looking at some Thunderbird issues, and if we should sync things or not. Its been gecko 1.9.2 since this was last used, so lets just drop it.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Attachment #8477896 - Flags: review?(mh+mozilla)
Attachment #8477896 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/8ce721baa271
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.