76328 - cvs-mirror checkout of security/ fails to find directories

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[James Green]

jg@cyberstorm:/usr/src/cvs/mozilla/mozilla$ make -f client.mk checkout
Adding client.mk options from /home/jg/.mozconfig:
    MOZ_OBJDIR=$(TOPSRCDIR)/../obj-opt
    MOZ_NSS_AUTOCONF=1
checkout start: Tue Apr 17 15:14:37 BST 2001
cvs -d :pserver:[e-mail]:/cvsroot -q -z 3 co -P
mozilla/client.mk mozilla/build/unix/modules.mk
make[1]: Entering directory `/usr/src/cvs/mozilla'
cvs -d :pserver:[e-mail]:/cvsroot -q -z 3 co -P -r
NSPRPUB_CLIENT_BRANCH mozilla/nsprpub
cvs -d :pserver:[e-mail]:/cvsroot -q -z 3 co -P -A
mozilla/security/manager
cvs -d :pserver:[e-mail]:/cvsroot -q -z 3 co -P -r
NSS_CLIENT_BRANCH mozilla/security/nss mozilla/security/coreconf
mozilla/security/build mozilla/security/Makefile.in mozilla/security/configure
mozilla/security/configure.in mozilla/security/secmakefiles.sh
mozilla/security/aclocal.m4
cvs server: existing repository /cvsroot/CVSROOT/Emptydir does not match
/cvsroot/mozilla/security
cvs server: ignoring module mozilla/security/Makefile.in
cvs server: existing repository /cvsroot/CVSROOT/Emptydir does not match
/cvsroot/mozilla/security
cvs server: ignoring module mozilla/security/configure
cvs server: existing repository /cvsroot/CVSROOT/Emptydir does not match
/cvsroot/mozilla/security
cvs server: ignoring module mozilla/security/configure.in
cvs server: existing repository /cvsroot/CVSROOT/Emptydir does not match
/cvsroot/mozilla/security
cvs server: ignoring module mozilla/security/secmakefiles.sh
cvs server: existing repository /cvsroot/CVSROOT/Emptydir does not match
/cvsroot/mozilla/security
cvs server: ignoring module mozilla/security/aclocal.m4
make[1]: *** [real_checkout] Error 1

From .mozconfig:
export MOZ_NSS_AUTOCONF=1
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-opt
mk_add_options MOZ_NSS_AUTOCONF=1
ac_add_options --enable-crypto

Working ok last night, maybe something broke in the process of mirroring?

Comment 1

[Dawn Endico]

This is a build issue, not a cvs-mirror issue. Changing component.

<jmkg> endico: interesting one that, it turns out that client.mk isn't being
patched to remove the calls for those dirs to be pulled
<jmkg> endico: Daa in #mozillazine sent me the patch, the pull went fine, and
now it's building to confirm psm2 still works
<Daa> endico: some combo of gmake and cvs hates the stock cleint.mk security
pull command ( pulling 5 non-existant files)
<Daa> cvs exits after pulling security and make aborts seeing the non-normal cvs
exit
<Daa> so all pulls in client.mk after security never occur

Comment 2

[Dawn Endico]

reassigning owner/qa contact to defaults for this component.

Comment 3

[James Green]

Seems to work, now seeing the same psm2 bugs everyone else is ;-)
Attaching the patch, perhaps someone would ensure people checking out will get
this change? I dunno why some people are and some people aren't...

Comment 4

[James Green]

Attachment: Patch to client.mk to stop checkout of now non-existant security/ dirs

Comment 5

[cls]

Those files weren't removed from client.mk so that they would be removed from
your tree when you checked out the files on the NSS_CLIENT_BRANCH.  I haven't
been able to reproduce this problem on 5 different boxes that I've changed to
start pulling the new branch.  I also pulled a fresh tree from cvs-mirror
without a problem.  Someone can check in the patch but I don't want to hear
people complaining about how files weren't removed when they switched over.  
The client branch isn't even live yet (but yes, it works for linux & solaris),
so this not a blocker.

Comment 6

[cls]

bounce

Comment 7

[Brian Ryner (not reading)]

Let's just go ahead and take these out instead of commenting them, they aren't
going to reappear.

Comment 8

[Brian Ryner (not reading)]

Attachment: patch #2

Comment 9

[cls]

knock yourself out. r=cls

Comment 10

[David Avery]

you wi8ll not see teh problem till you pull the same tree from cvs-mirror
2 times

Comment 11

[Brian Ryner (not reading)]

Checked in.

Comment 12

[Jon Granrose]

verified.