763334 - possibly obsolete css in filterDialog.css: listcell[enabled="false"]

Status: RESOLVED INVALID

(Thunderbird :: Theme, defect)

Description

[:aceman]

I found these lines in mail/themes/gnomestripe/mail/filterDialog.css :

listcell[enabled="false"] {
  list-style-image: url("chrome://messenger/skin/icons/notchecked.gif");
}

listcell[enabled="true"] {
  list-style-image: url("chrome://messenger/skin/icons/check.gif");
}

I am not sure those are ever used in the current filter editor. It looks like remnants from the old filter editor where the various filter actions had checks besides them to indicated they are enabled. That is not used anymore.

Seamonkey has something similar:
treechildren::-moz-tree-image(activeColumn) {
  list-style-image: url("chrome://messenger/skin/icons/dot.png");
}

treechildren::-moz-tree-image(activeColumn, Enabled-true) {
 list-style-image: url("chrome://messenger/skin/icons/check.png");
}

If these lines are not needed anymore I would remove them from all the themes of TB and SM.

Comment 1

[Philip Chee]

For SeaMonkey MailNews, I'd ask IanN or Mnyromyr

Comment 2

[:aceman]

Attachment: patch

Requesting ui-r to check there are no UI changes :)

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 635009 [details] [diff] [review]
patch

ui-r-, because you can see the difference at https://dl.dropbox.com/u/2301433/Screenshots/FilterReview.png, and it seems like a step backwards.  ;)

Thanks,
Blake.

Comment 4

[:aceman]

Oh, the filterDialog.css is used also in the filterListDialog, not only the filterEditor. So that css is used. Sorry for bothering all of you.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 635009 [details] [diff] [review]
patch

Removing now obsolete review request.