possibly obsolete css in filterDialog.css: listcell[enabled="false"]

RESOLVED INVALID

Status

Thunderbird
Theme
--
trivial
RESOLVED INVALID
6 years ago
6 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I found these lines in mail/themes/gnomestripe/mail/filterDialog.css :

listcell[enabled="false"] {
  list-style-image: url("chrome://messenger/skin/icons/notchecked.gif");
}

listcell[enabled="true"] {
  list-style-image: url("chrome://messenger/skin/icons/check.gif");
}

I am not sure those are ever used in the current filter editor. It looks like remnants from the old filter editor where the various filter actions had checks besides them to indicated they are enabled. That is not used anymore.

Seamonkey has something similar:
treechildren::-moz-tree-image(activeColumn) {
  list-style-image: url("chrome://messenger/skin/icons/dot.png");
}

treechildren::-moz-tree-image(activeColumn, Enabled-true) {
 list-style-image: url("chrome://messenger/skin/icons/check.png");
}

If these lines are not needed anymore I would remove them from all the themes of TB and SM.

Comment 1

6 years ago
For SeaMonkey MailNews, I'd ask IanN or Mnyromyr
(Assignee)

Comment 2

6 years ago
Created attachment 635009 [details] [diff] [review]
patch

Requesting ui-r to check there are no UI changes :)
Attachment #635009 - Flags: ui-review?(bwinton)
Attachment #635009 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Comment on attachment 635009 [details] [diff] [review]
patch

ui-r-, because you can see the difference at https://dl.dropbox.com/u/2301433/Screenshots/FilterReview.png, and it seems like a step backwards.  ;)

Thanks,
Blake.
Attachment #635009 - Flags: ui-review?(bwinton) → ui-review-
(Assignee)

Comment 4

6 years ago
Oh, the filterDialog.css is used also in the filterListDialog, not only the filterEditor. So that css is used. Sorry for bothering all of you.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
Comment on attachment 635009 [details] [diff] [review]
patch

Removing now obsolete review request.
Attachment #635009 - Flags: review?(iann_bugzilla)
You need to log in before you can comment on or make changes to this bug.