Clean up some includes in content/ and dom/

RESOLVED FIXED in mozilla16

Status

()

defect
RESOLVED FIXED
7 years ago
4 months ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

7 years ago
Posted patch PatchSplinter Review
No description provided.
Attachment #631776 - Flags: review?(jonas)
Assignee

Comment 1

7 years ago
I can ask someone else for review on the accessible/ parts if needed.
(In reply to David Zbarsky from comment #1)
> I can ask someone else for review on the accessible/ parts if needed.

I took a quick look out of curiosity, and it seems fine.  thanks!
Assignee

Updated

7 years ago
Attachment #631776 - Flags: review?(jonas) → review?(bugs)
Comment on attachment 631776 [details] [diff] [review]
Patch

>diff --git a/content/events/public/nsMutationEvent.h b/content/events/public/nsMutationEvent.h
>--- a/content/events/public/nsMutationEvent.h
>+++ b/content/events/public/nsMutationEvent.h
>@@ -1,21 +1,18 @@
> /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this
>  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> 
> #ifndef nsMutationEvent_h__
> #define nsMutationEvent_h__
> 
>-#include "nsGUIEvent.h"
> #include "nsIDOMNode.h"
> #include "nsIAtom.h"
>-#include "nsIDOMEventTarget.h"
>-#include "nsIContent.h"
> 
> class nsMutationEvent : public nsEvent
> {
> public:
>   nsMutationEvent(bool isTrusted, PRUint32 msg)
>     : nsEvent(isTrusted, msg, NS_MUTATION_EVENT),
>       mAttrChange(0)
>   {
So whoever includes nsMutationEvent.h, must include nsGUIEvent.h?
Doesn't feel right.


>+++ b/content/events/src/nsDOMDeviceLightEvent.cpp
>@@ -1,14 +1,14 @@
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>  * You can obtain one at http://mozilla.org/MPL/2.0/. */
> 
>+#include "nsDOMClassInfoID.h"
> #include "nsDOMDeviceLightEvent.h"
>-#include "nsContentUtils.h"
> #include "DictionaryHelpers.h"

These changes are so going to break one my patch, but I'll fix it.
(I'm doing the same thing in that patch.)

Make sure to push this to tryserver.
r=me with the nsMutationEvent.h fixed.
Attachment #631776 - Flags: review?(bugs) → review+
Assignee

Comment 4

7 years ago
Pushed with the nsMutationEvent.h change
https://hg.mozilla.org/integration/mozilla-inbound/rev/2068c7dda3a2
Flags: in-testsuite-
Target Milestone: --- → mozilla16

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/2068c7dda3a2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.