763647 - [NativeUI GA] implementation bug for /new updates

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

Implementation bug for the updates to mozilla.org/firefox/new as covered in bug 749825.

Comment 1

[Lee Tom]

Link to PSD here:
http://cl.ly/3e2i3R110Q0e2d271C3e

Comment 2

[[github robot]]

Commits pushed to dev at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/91a7ea8ad7443248c8f2ecb754c3b8a4bd1a5863
Bug 763647 - [NativeUI GA] implementation bug for /new updates

https://github.com/mozilla/bedrock/commit/b64009d1afef2144fa7dc309afd03e78872eef28
Merge pull request #180 from sgarrity/bug-763647-fennec-new

Bug 763647 Fennec updates to /new page

Comment 3

[Steven Garrity [:sgarrity]]

This is ready for qa: http://www-dev.allizom.org/en-US/firefox/new/

Comment 4

[Matej Novak [:matej]]

One little thing here: Can we make "free" lowercase in the Android button? Thanks.

Also, are we good still using the Georgia italics for the three points under the headline?

Comment 5

[[e-mail]]

Hello

Was the only change / add to this page the Android Button?  

If so, could we take another looks at the button?  It does not look aligned with the main download button.  Messages seem to be right aligned and diminishing in importance.  

Also, are we using the same font in the Android callout as we are in the download button? There seem to be a medley of fonts on the page.  

thanks

Comment 6

[John Slater]

> Was the only change / add to this page the Android Button?  

yep!
 
> If so, could we take another looks at the button?  It does not look aligned
> with the main download button.  Messages seem to be right aligned and
> diminishing in importance.  

Lee, can you jump in and share your thinking here?
 
> Also, are we using the same font in the Android callout as we are in the
> download button? There seem to be a medley of fonts on the page.  

Yes and no...there are a couple of fonts on the desktop download button, and one of them is being reused on the Android callout.

Comment 7

[Steven Garrity [:sgarrity]]

(In reply to Matej Novak [:matej] from comment #4)
> One little thing here: Can we make "free" lowercase in the Android button?
Done.

(In reply to [e-mail] from comment #5)
> Was the only change / add to this page the Android Button?  
> 
> If so, could we take another looks at the button?  It does not look aligned
> with the main download button.  Messages seem to be right aligned and
> diminishing in importance.  
> Also, are we using the same font in the Android callout as we are in the
> download button? There seem to be a medley of fonts on the page.  

The implementation matches the PSD fairly faithfully, though I think this is a good criticism. We're using 7 variations of font face/size/style/color in as many lines.

I'll defer to the designers for specific updates. Since there aren't any regressions here though, (the page is almost identical to the current production page), I would suggest we go with this for Tuesday and improve after that.

Comment 8

[Lee Tom]

There is a medley of fonts on this page... hm. Is it possible to make the Android button the same width as the desktop button? Also, let's change the font of the Android button from Georgia to Open Sans if it's not too much trouble.

Comment 9

[Steven Garrity [:sgarrity]]

I've made some minor changes based on Lee's feedback. The android button is a bit larger, the font is the Open Sans font, and the Free Download font color in the main Firefox download button is now the light green as per the mockup.