763704 - DOMRequest callbacks should fire for launched mozApp

Status: RESOLVED WONTFIX

(Core Graveyard :: DOM: Apps, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

In Gaia, we call launch() on the App, and get back a DOMRequest, but it doesn't fire the callbacks. For example, running something like this in the content space:

window.wrappedJSObject.appscreen.getAppByOrigin('http://calculator.gaiamobile.org').launch();

returns a DOMRequest object, but if I do:


window.wrappedJSObject.appscreen.getAppByOrigin('http://calculator.gaiamobile.org').launch(.onsuccess = function(){alert('App is launched!');};

The callback will never fire.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

erm, weird typo:

window.wrappedJSObject.appscreen.getAppByOrigin('http://calculator.gaiamobile.org').launch().onsuccess = function(){alert('App is launched!');};

Comment 2

[Boris Zbarsky [:bzbarsky]]

Does launch() return a new object?

Can that object get GCed?

Comment 3

[[:fabrice] Fabrice Desré]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Does launch() return a new object?
> 
> Can that object get GCed?

Yes, it returns a DOMRequest.

Comment 4

[Boris Zbarsky [:bzbarsky]]

That doesn't answer my second question.  Can you point me to the launch() implementation, please?

Comment 5

[[:fabrice] Fabrice Desré]

It's there:
http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.js#238 which uses http://mxr.mozilla.org/mozilla-central/source/dom/base/DOMRequestHelper.jsm#94 to create the DOMRequest using the DOMRequestService.

The cause for the problem reported is known, we return the request object but never fire .onsuccess or .onerror on it.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Looking through that code, it looks at first glance like nothing holds on to the request, so can never fire an event on it, yeah....

Comment 7

[[:fabrice] Fabrice Desré]

We hold on to the request when calling getRequestId(). But even if we can fire events, we don't.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Core Graveyard / DOM: Apps is inactive. Closing all bugs in this component.