763777 - [Ratings] Allow developers to edit their ratings

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

We allow developers to edit reviews on AMO: https://github.com/mozilla/zamboni/blob/master/apps/reviews/views.py#L204

We should allow the same on the Marketplace. Use some AJAX, and let's make it happen, cap'n!

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/e4cf2de

A few outstanding issues I've noticed:

- missing error handling when I enter an empty review ('', ' ', '\n', etc.) or if there are > 150 characters.
- missing the character counter like we have for submission (150 characters or fewer).
- if the review is exactly the same do not save another.
- if I edit the review and there was a developer reply, you no longer see the developer reply since it corresponded to a separate review!
- when I click Cancel it takes two clicks to dismiss the modal.
- clean up margins, buttons, etc.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

When I edit a review it says "Your review was successfully added!" http://cl.ly/0p1s0Q3h1P2T2m082835

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Also, when I try to edit a reply it 403s on me because that's effectively the same as writing a *new* review for my own app.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/cvan/zamboni/commit/f1b25e2

I think Basta has fixed pretty much all these issues.

Comment 5

[krupa raj[:krupa]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #3)
> Also, when I try to edit a reply it 403s on me because that's effectively
> the same as writing a *new* review for my own app.

[16:49:45.899] POST https://marketplace-dev.allizom.org/en-US/app/seevans-underworld-adventur-11/reviews/add [HTTP/1.1 403 FORBIDDEN 57ms]

Comment 6

[Matt Basta [:basta]]

Done

https://github.com/mozilla/zamboni/commit/2cf81d1b8bd7e269445d979aa6690aafb3902da4