Last Comment Bug 763778 - use PREF_JS_EXPORTS to preprocess/install webapp runtime's default prefs file
: use PREF_JS_EXPORTS to preprocess/install webapp runtime's default prefs file
Status: RESOLVED FIXED
[qa-]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Webapp Runtime (show other bugs)
: 14 Branch
: All All
: P3 normal
: Firefox 16
Assigned To: Myk Melez [:myk] [@mykmelez]
: Jason Smith [:jsmith]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-11 17:18 PDT by Myk Melez [:myk] [@mykmelez]
Modified: 2016-03-21 12:39 PDT (History)
2 users (show)
jsmith: in‑moztrap-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1: makes webapprt/Makefile.in use PREF_JS_EXPORTS (829 bytes, patch)
2012-06-11 17:18 PDT, Myk Melez [:myk] [@mykmelez]
benjamin: review+
myk: checkin+
Details | Diff | Review

Description Myk Melez [:myk] [@mykmelez] 2012-06-11 17:18:53 PDT
Created attachment 632076 [details] [diff] [review]
patch v1: makes webapprt/Makefile.in use PREF_JS_EXPORTS

The build system preprocesses and installs default prefs files specified by PREF_JS_EXPORTS, but the webapp runtime's Makefile doesn't use that macro.  It seems like it should, so as not to repeat ourselves, and in case the file ever needs preprocessing.

Here's a patch that makes the change.
Comment 1 Myk Melez [:myk] [@mykmelez] 2012-06-14 13:28:53 PDT
Comment on attachment 632076 [details] [diff] [review]
patch v1: makes webapprt/Makefile.in use PREF_JS_EXPORTS

https://hg.mozilla.org/integration/mozilla-inbound/rev/9191e3007100
Comment 2 Ed Morley [:emorley] 2012-06-15 05:58:22 PDT
https://hg.mozilla.org/mozilla-central/rev/9191e3007100
Comment 3 Jason Smith [:jsmith] 2012-06-15 07:03:37 PDT
Looks like an internal code change - no verification needed.

Note You need to log in before you can comment on or make changes to this bug.