use PREF_JS_EXPORTS to preprocess/install webapp runtime's default prefs file

RESOLVED FIXED in Firefox 16

Status

Firefox Graveyard
Webapp Runtime
P3
normal
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: myk, Assigned: myk)

Tracking

14 Branch
Firefox 16
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 632076 [details] [diff] [review]
patch v1: makes webapprt/Makefile.in use PREF_JS_EXPORTS

The build system preprocesses and installs default prefs files specified by PREF_JS_EXPORTS, but the webapp runtime's Makefile doesn't use that macro.  It seems like it should, so as not to repeat ourselves, and in case the file ever needs preprocessing.

Here's a patch that makes the change.
Attachment #632076 - Flags: review?(benjamin)
(Assignee)

Updated

5 years ago
Priority: -- → P3
Target Milestone: --- → Firefox 16
Attachment #632076 - Flags: review?(benjamin) → review+
(Assignee)

Comment 1

5 years ago
Comment on attachment 632076 [details] [diff] [review]
patch v1: makes webapprt/Makefile.in use PREF_JS_EXPORTS

https://hg.mozilla.org/integration/mozilla-inbound/rev/9191e3007100
Attachment #632076 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/9191e3007100
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Looks like an internal code change - no verification needed.
Whiteboard: [qa-]

Updated

5 years ago
Flags: in-moztrap-

Updated

5 years ago
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.