763787 - Consistent verb tense in output of POST /storage/collection

Status: VERIFIED WONTFIX

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

Attachment: patch changing "success" to "succeeded"

The output of POST /storage/collection is a JSON object with the following keys:

    * success: a list of ids of BSOs that were successfully stored.
    * failed: an object whose keys are the ids of BSOs that were not stored successfully, and whose values are lists of strings describing possible reasons for the failure.

This is a strange mix of tenses between "success" and "failed".  I propose changing it to "succeeded" and "failed" for consistency.

Comment 1

[Toby Elliott [:telliott]]

success and failed sound OK to me, but whatever. Can't explain it. I would recommend changing them to success and fail rather than the past tense, if only to save on the bytes.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 632092 [details] [diff] [review]
patch changing "success" to "succeeded"

Review of attachment 632092 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Toby. And, I can't explain it either.

Comment 3

[Ryan Kelly [:rfkelly]]

Fair enough, I'm glad I brought it up but will not mention it again :-)

Comment 4

[James Bonacci [:jbonacci]]

Ha! ok. Verifying as a never gonna fix...