If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Consistent verb tense in output of POST /storage/collection

VERIFIED WONTFIX

Status

Cloud Services
Server: Sync
VERIFIED WONTFIX
5 years ago
5 years ago

People

(Reporter: rfkelly, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 632092 [details] [diff] [review]
patch changing "success" to "succeeded"

The output of POST /storage/collection is a JSON object with the following keys:

    * success: a list of ids of BSOs that were successfully stored.
    * failed: an object whose keys are the ids of BSOs that were not stored successfully, and whose values are lists of strings describing possible reasons for the failure.

This is a strange mix of tenses between "success" and "failed".  I propose changing it to "succeeded" and "failed" for consistency.
Attachment #632092 - Flags: review?(gps)
success and failed sound OK to me, but whatever. Can't explain it. I would recommend changing them to success and fail rather than the past tense, if only to save on the bytes.
Whiteboard: [qa+]
Comment on attachment 632092 [details] [diff] [review]
patch changing "success" to "succeeded"

Review of attachment 632092 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Toby. And, I can't explain it either.
Attachment #632092 - Flags: review?(gps) → review-
(Reporter)

Comment 3

5 years ago
Fair enough, I'm glad I brought it up but will not mention it again :-)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
Ha! ok. Verifying as a never gonna fix...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.