763994 - Can't load email campaign

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Ludovic Hirlimann [:Usul]]

I created an email campaing and when I saved it I got the following :

Uh oh! Something went wrong...

    Error loading recent email campaigns 

Campaign saved70
Unable to load campaign.


url was https://crash-stats.mozilla.com/admin/email_campaign/70

Comment 1

[Robert Helmer [:rhelmer]]

Here is the exception:

Jun 12 09:17:02 Socorro Web Services (pid 19104): 2012-06-12 09:17:02,803 ERROR - Dummy-3 - invalid literal for int() with base 10: 'rawurlencode(70)'
Jun 12 09:17:02 Socorro Web Services (pid 19104): 2012-06-12 09:17:02,803 ERROR - Dummy-3 - trace back follows:
Jun 12 09:17:02 Socorro Web Services (pid 19104): 2012-06-12 09:17:02,803 ERROR - Dummy-3 - Traceback (most recent call last):
Jun 12 09:17:02 Socorro Web Services (pid 19104): 2012-06-12 09:17:02,803 ERROR - Dummy-3 - File "/data/socorro/application/socorro/webapi/webapiService.py", line 60, in GET#012    result = self.get(*args)
Jun 12 09:17:02 Socorro Web Services (pid 19104): 2012-06-12 09:17:02,804 ERROR - Dummy-3 - File "/data/socorro/application/socorro/services/emailCampaign.py", line 27, in get#012    id = int(args[0])
Jun 12 09:17:02 Socorro Web Services (pid 19104): 2012-06-12 09:17:02,804 ERROR - Dummy-3 - ValueError: invalid literal for int() with base 10: 'rawurlencode(70)'

I suspect this is a regression from bug 733107, but I am not sure exactly how this is breaking from looking at the code.. it looks like "rawurlencode(70)" is literally getting passed, instead of the encoded value?

In any case $token should always be an int so I am not sure we really should be URL encoding here at all.

Comment 2

[Laura Thomson :laura]

Adrian, can you please take a look?

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6ecda5b0d5834359e870281e0d80f1eba02f6dfd
Fixes bug 763994 - Remove the wrong rawurlencode in URL for email campaigns.

https://github.com/mozilla/socorro/commit/9ea4f9fcea9c7740d5f2208541a5f6c52d33dcb0
Merge pull request #647 from AdrianGaudebert/763994-fix-email-campaigns

Fixes bug 763994 - Remove the wrong rawurlencode in URL for email campaigns.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Testing is blocked on bug 764906 for the moment.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Log in
2. Go to admin panel and then to email campaigns
3. Create a new campaign with fake version and data
4. On the second screen, make sure 0 users will be emailed
5. Verify that the campaign gets created by validating the previous step
6. Go back to the email campaign first page and check that your test campaign shows up in the campaign list at the bottom of the page.

Comment 6

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened - server error when saving campaign

Reopened:
I wonder if the code hasn't landed on stage - when I create a campaign and click 'next step' I get a server error.

Steps to reproduce:
1. goto https://crash-stats.allizom.org/admin/email
2. create a campaign 
3. click 'next step'

Expected:
it works

Actual:
After clicking 'next step' I'm taken to https://crash-stats.allizom.org/admin/confirm_email but there is a notice of a server error.

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

@Matt: I can't reproduce on stage anymore, I suppose this happened because of the DB problem. Can you please try again? 

Moving back to 13, this is in stage branch already.

Comment 8

[Matt Brandt [:mbrandt]]

Bumping to resolved fixed per comment 7.

Comment 9

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened - server error when saving campaign

Reopening: sorry adrian - I'm still seeing what appears to be the same error that I mentioned in comment 6.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d4add37bf3c7b005db0a8844a381f8175612317a
Revert "Fixes bug 763994 - Remove the wrong rawurlencode in URL for email campaigns."

This reverts commit 6ecda5b0d5834359e870281e0d80f1eba02f6dfd.

https://github.com/mozilla/socorro/commit/878813fc54016ea7125e3c1c168ed836a1f41b4c
Merge pull request #665 from Lonnen/revert-fix-for-763994

Revert "Fixes bug 763994"

Comment 11

[[DEACTIVATED] Adrian Gaudebert]

@Matt: I'd like to know what you do exactly, because I can't reproduce on stage. Especially, what signature do you test with?

Comment 12

[Matt Brandt [:mbrandt]]

Attachment: qa - expected error message

(In reply to Adrian Gaudebert [:adrian] from comment #11)
> @Matt: I'd like to know what you do exactly, because I can't reproduce on
> stage. Especially, what signature do you test with?

I love spurious errors - I can't reproduce it anymore either - although I've been able to reproduce a similar server error by leaving out a signature.

Steps to reproduce:
1. goto https://crash-stats.allizom.org/admin/email
2. create a campaign - but leave the 'Exact signature' field blank
3. click 'next step'

Expected:
If the 'Exact signature' field is blank and the 'next step' button is clicked an error message should be presented to the user letting them know this field is required.

Actual:
Clicking the 'next step' successful submits the form and redirects to https://crash-stats.allizom.org/admin/confirm_email. A generic server error message is presented to the user.

Comment 13

[[DEACTIVATED] Adrian Gaudebert]

This is a different problem, and not a regression, thus it has its own bug: bug 767391. 

This one is indeed resolved! :)

Comment 14

[Schalk Neethling [:espressive]]

[:mbrandt] Are there any other fields that are either required or, that needs to be in a specific format? There was a bug open to do proper validation on this form but was closed for some reason, cannot remember why ;)

Comment 15

[Matt Brandt [:mbrandt]]

(In reply to Adrian Gaudebert [:adrian] from comment #13)
> This one is indeed resolved! :)
Thanks adrian for pushing through this - bumping to QA verified

> There was a bug open to do proper validation on this form but was closed for some
> reason, cannot remember why ;)

Well there should be both form validation and likely some input validation. I'm not sure which bug you're referring. My bugzilla foo is weak on this fine Friday.