Last Comment Bug 764054 - visually distinguish / separate menu bar and toolbar
: visually distinguish / separate menu bar and toolbar
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-12 11:14 PDT by Wayne Mery (:wsmwk, NI for questions)
Modified: 2012-08-20 14:00 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
compose pane and 3pane (158.77 KB, image/png)
2012-06-12 11:14 PDT, Wayne Mery (:wsmwk, NI for questions)
no flags Details
proposal (38.27 KB, image/png)
2012-08-13 05:19 PDT, Richard Marti (:Paenglab)
bugs: feedback+
Details
patch (719 bytes, patch)
2012-08-13 05:49 PDT, Richard Marti (:Paenglab)
bugs: review+
bugs: ui‑review+
Details | Diff | Splinter Review

Description Wayne Mery (:wsmwk, NI for questions) 2012-06-12 11:14:03 PDT
Created attachment 632330 [details]
compose pane and 3pane

menu bar and toolbar seem like one big mass. in my case, a mass of blue (see screen shot), which makes it hard to find the menu bar.

need to visually distinguish / separate menu bar and toolbar - with shades of color, or divider, or both.
Comment 1 Wayne Mery (:wsmwk, NI for questions) 2012-06-12 11:14:53 PDT
plus, it looks bland.

BTW, this is default theme
Comment 2 Andreas Nilsson (:andreasn) 2012-06-12 20:12:32 PDT
I agree and I think just a 1px line would do the trick here.
Comment 3 Richard Marti (:Paenglab) 2012-08-13 05:19:24 PDT
Created attachment 651331 [details]
proposal

What do you say to this border color? It's the same color as the toolbox bottom color.
Comment 4 Andreas Nilsson (:andreasn) 2012-08-13 05:34:25 PDT
Comment on attachment 651331 [details]
proposal

Looks good.
Comment 5 Richard Marti (:Paenglab) 2012-08-13 05:49:08 PDT
Created attachment 651338 [details] [diff] [review]
patch

Patch doing the border like in proposal screenshot.
Comment 6 Andreas Nilsson (:andreasn) 2012-08-19 12:37:07 PDT
Comment on attachment 651338 [details] [diff] [review]
patch

Looks good!
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-08-20 14:00:35 PDT
https://hg.mozilla.org/comm-central/rev/3b3afaad8f97

Note You need to log in before you can comment on or make changes to this bug.