764097 - [traceback] KeyError: 'sort'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Post bug 764070, there's a keyError on 'sort', with https://builder-addons-dev.allizom.org/search/?type=a&featured=0&example=1&sort=%3C/script%3E%3Cscript%3Ealert%28%223%22%29%3C/script%3Eforked:

Traceback (most recent call last):

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/search/views.py", line 122, in search
    return _render(request, template, ctx)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/search/views.py", line 138, in _render
    return render_to_response(template, data, RequestContext(request))

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/shortcuts/__init__.py", line 20, in render_to_response
    return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/template/loader.py", line 188, in render_to_string
    return t.render(context_instance)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/src/jingo/jingo/__init__.py", line 189, in render
    return super(Template, self).render(context_dict)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/search/templates/results.html", line 1, in top-level template code
    {% extends "base.html" %}

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/base/templates/base.html", line 79, in top-level template code
    {% block base_fluid_width %}

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/base/templates/base.html", line 85, in block "base_fluid_width"
    {% block app_content %}{% endblock %}

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/search/templates/results.html", line 24, in block "app_content"
    {% include "_results.html" %}

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/search/templates/_results.html", line 10, in top-level template code
    <option value="activity" {{ select_selected('sort=activity') }}>Activity</option>

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/search/helpers.py", line 120, in select_selected
    if context['request'].GET.get(bits[0]) == bits[1] or context.get('query')[bits[0]] == bits[1]:

KeyError: 'sort'

Comment 1

[Sean McArthur [:seanmonstar]]

fixed with this commit: https://github.com/mozilla/FlightDeck/commit/b8483d8e8256a94a581827ec3c7b37485e031ad6

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks.